Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REBAR_CONFIG does not work in bare compiler #1383

Closed
ericmj opened this issue Nov 21, 2016 · 2 comments
Closed

REBAR_CONFIG does not work in bare compiler #1383

ericmj opened this issue Nov 21, 2016 · 2 comments

Comments

@ericmj
Copy link
Contributor

ericmj commented Nov 21, 2016

The app_discovery provider the bare compiler depends on loads the rebar.config without checking REBAR_CONFIG first.
@ericmj
Copy link
Contributor Author

ericmj commented Nov 21, 2016

I can send a PR for this.

Is the correct fix to replace all ?DEFAULT_CONFIG_FILE with a REBAR_CONFIG lookup? If not I need some guidance first.

@ferd
Copy link
Collaborator

ferd commented Nov 21, 2016

I think this would be a good first fix to try. If it works we're good, if it doesn't then we'll need to dig some more.

@ericmj ericmj mentioned this issue Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferd @ericmj