Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Hex packages support #1776

Closed
haljin opened this issue May 4, 2018 · 7 comments
Closed

Private Hex packages support #1776

haljin opened this issue May 4, 2018 · 7 comments

Comments

@haljin
Copy link

haljin commented May 4, 2018

After scouring the code and the examples it seems rebar3 does not have support for private Hex.pm packages. Majority of our code is still Erlang and not Elixir and we would really like to use this feature.

Is that something that is planned or did I miss something and it's possible to use private packages from rebar3?

@ferd
Copy link
Collaborator

ferd commented May 4, 2018

They are currently not supported.
We need to at the very least get to the newest Hex API first, but I have to say that we have no plans on the table for the private hex repos at this time. I haven't read the doc on how they work.

I've documented the current plans we had in mind at #1777 -- you'll see that private hex repos right now are in the 'nice to have' category, which means that unless it's not that much work to support, we may not expand the effort to do it very early on, although contributions would be welcome. The challenge is getting the project in the right place to even make it there first, though.

@ericmj
Copy link
Contributor

ericmj commented May 4, 2018

When Hex registry v2 and multi-repo support is added it shouldn't be too much work to support private packages if I understand the rebar plans for multi-repo correctly. For basic support it should only be a matter of adding an authentication key to the repository configuration and using this for the HTTP requests. I would be happy to contribute this.

@ferd
Copy link
Collaborator

ferd commented May 4, 2018

Is the authentication key an environment thing that should ideally be hidden, or a more public token that can be checked in config files and/or code?

@ericmj
Copy link
Contributor

ericmj commented May 4, 2018

The authentication key gives read access to the repository so it should be hidden or only checked in to private source control.

@tsloughter
Copy link
Collaborator

@haljin if you or someone on your team is interested in helping I think the first step is switching rebar3 to use https://github.com/hexpm/hex_erl for finding and downloading dependencies.

Correct me if I'm wrong there @ferd and @ericmj

@ferd
Copy link
Collaborator

ferd commented Jun 6, 2018

That is correct. Also see #1777 for the current roadmap, even if little start has started yet.

@tsloughter
Copy link
Collaborator

@haljin support for private packages has been added in 3.7.0-rc1. I'm closing this issue, please open a new one if you have any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants