Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace querysting with either URLSearchParams or a faster alternative #149

Open
outslept opened this issue Jan 21, 2025 · 3 comments
Open
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each

Comments

@outslept
Copy link

outslept commented Jan 21, 2025

We should migrate to using the native URLSearchParams rather than the querystring package.

If nesting is required, we should use fast-querystring or nested-querystring

Concerns: afaik if a user provides a large number of param values the API would be slow.

Most of those repos below are known/used, but I don't really know if maintainers are into this idea

npx github:Fuzzyma/e18e-tools querystring -n 20 -q -o md  -U https://npm.devminer.xyz/registry > querystring-output.md
# Downloads Traffic Version Package Issues
1 39.62M 135.32 GB 0.2.0 aws-sdk #150
2 4.07M 13.89 GB ^0.2.1 @serverless/platform-client
3 3.30M 11.27 GB ^0.2.0 native-url
4 424.88k 1.45 GB ^0.2.0 @serverless/platform-client-china
5 255.94k 874.04 MB ^0.2.1 smartling-api-sdk-nodejs
6 134.83k 460.43 MB ^0.2.1 vite-plugin-vue2
7 126.41k 431.67 MB 0.2.0 node-quickbooks
8 118.91k 406.07 MB 0.2.0 gravatar
9 116.29k 397.14 MB ^0.2.0 @serverless/platform-sdk
10 111.83k 381.91 MB ^0.2.0 middy
11 105.51k 360.32 MB 0.2.0 sib-api-v3-sdk
12 97.50k 332.95 MB ^0.2.0 remote-redux-devtools
13 85.26k 291.16 MB ^0.2.0 plivo
14 76.02k 259.60 MB ^0.2.1 @pipedream/platform
15 69.83k 238.48 MB ^0.2.0 @vercel/client
16 59.69k 203.84 MB 0.2.0 clickhouse
17 53.31k 182.07 MB ^0.2.0 samlp
18 52.30k 178.59 MB 0.2.1 etherscan-api
19 48.39k 165.26 MB ^0.2.0 @r2u/javascript-ar-sdk
20 40.88k 139.62 MB ^0.2.0 @itentialopensource/adapter-utils
@43081j
Copy link
Collaborator

43081j commented Jan 21, 2025

You can also use picoquery in places which need deep nesting or configurability

Though ideally we just use native ofc

@Fuzzyma Fuzzyma added the umbrella issue This issue contains a list of dependents of a package and tracks the progress in each label Jan 22, 2025
@leefreemanxyz
Copy link

The aws-sdk listed here (v2) appears to be in maintenance mode and will reach EOL in September 2025 - it looks like querystring isn't used in aws-sdk v3, maybe it's better to target packages that depend on aws-sdk v2 and try opening PRs to v3?

@Fuzzyma
Copy link
Collaborator

Fuzzyma commented Jan 22, 2025

Why would they create a new repo for v3? -.-
But you definitely hit something there. Soooo many huge packages depending on v2.
But I guess migrating is not that easy. They have a codemod tho

Created an issue: #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella issue This issue contains a list of dependents of a package and tracks the progress in each
Projects
None yet
Development

No branches or pull requests

4 participants