Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IEEE compliancy in floating point min/max reductions on LLVM verson that supports it #130

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

KristofferC
Copy link
Collaborator

@KristofferC KristofferC commented Oct 29, 2024

Fixes #129

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (48a8a4e) to head (41139b4).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   88.49%   88.86%   +0.37%     
==========================================
  Files           5        5              
  Lines         565      566       +1     
==========================================
+ Hits          500      503       +3     
+ Misses         65       63       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschnett
Copy link
Owner

IEEE actually defines a "minimum" reduction that ignores nans. (I know, I know...) I would thus argue with "make min behave the same as everywhere else in Julia", not with IEEE compliance. (I agree with the change in this PR.)

@KristofferC
Copy link
Collaborator Author

I would thus argue with "make min behave the same as everywhere else in Julia", not with IEEE compliance.

Yes, I agree (but that is also what this PR should do).

@KristofferC KristofferC merged commit 7739d91 into master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce(min, Vec) doesn't respect IEEE 754
3 participants