Fixed new cal api amount field

[orzarchi]

The CAL scraper is currently mixing up the converted amount and original amount in foreign transactions
Here's some real life data:

{
  ...
  "merchantName": "RYANAIR",
  "trnAmt": 175.09,
  "trnCurrencySymbol": "€",
  "trnType": "רגילה",
  "trnTypeCode": "5",
  "amtBeforeConvAndIndex": 664.38,
  "debCrdCurrencySymbol": "₪",
  "comments": [
    {
      "key": "סכום הנחה בעמלת עסקאות מט\"ח",
      "value": "11.84"
    },
    {
      "key": "עמלת עסקת מט\"ח",
      "value": "18.42"
    },
    {
      "key": "עסקה עם הנחה בעמלת מט\"ח",
      "value": ""
    },
    {
      "key": "בתאריך 01/02/2023 בוצעה המרה ל-₪ בשער יציג 3.757",
      "value": ""
    }
  ],
  "transTypeCommentDetails": [
    "סכום העסקה - €175.09"
  ],
  ...
}

I don't blame the code, that's a VERY confusing api 😆
@baruchiro can you please take a look? 😄

[orzarchi]

Upon further examination, we should always use amtBeforeConvAndIndex as the charged amount, for all currencies.
Other than foreign transaction, trnAmt is also incorrect when you get "discounted transactions" because of your loyalty club:

{
...
  "trnNumaretor": 2,
  "trnAmt": 164,
  "trnCurrencySymbol": "₪",
  "trnType": "רגילה",
  "trnTypeCode": "5",
  "amtBeforeConvAndIndex": 147.6,
  "debCrdCurrencySymbol": "₪",
  "discountAmount": "₪16.4",
  ...
}

[esakal]

@orzarchi is this one ready to be merged? I don't have an account there so I cannot verify the change by myself

[orzarchi]

yep, I verified it

[github-actions]

🎉 This PR is included in version 3.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀