fix(beinleumi): added support for balance over 100K #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test with input examples and their expected output? |
|
Sure. Do you have an example of a unit test format you are using? The
beinLeumi tests are really high level, and I don't see unit tests.
…On Sun, May 5, 2024 at 10:34 PM Baruch Odem (Rothkoff) < ***@***.***> wrote:
Can you add a unit test with input examples and their expected output?
—
Reply to this email directly, view it on GitHub
<#853 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5BWKKHMC3ASCJWENRCY33ZA2CUVAVCNFSM6AAAAABHHXLV7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHEZDGMBVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@baruchiro I don't have this type of account but It looks legit from the code. do you want to wait for a unit test or to merge? |
baruchiro
approved these changes
Jul 11, 2024
baruchiro
changed the title
baruchiro
changed the title
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balances on BeinLeumi for over 100K are shown with number of commas. Changed replace to replaceAll, also added replace of NIS_CURRENCY_SYMBOL which appears if you have number of foreign accounts.