Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies versions & security vulnerabilities #855

Closed
yanivfranco opened this issue Jun 7, 2024 · 6 comments
Closed

Dependencies versions & security vulnerabilities #855

yanivfranco opened this issue Jun 7, 2024 · 6 comments
Labels

Comments

@yanivfranco
Copy link
Contributor

yanivfranco commented Jun 7, 2024

First, I want say thanks to all the contributors of this project! it is awesome and useful.

The only problem is that most of the dependencies of this repository are SUPER outdated, resulting in lots of security vulnerabilities. This is a big issue when this project is used to access some very sensitive information.
Are there any plans on updating the dependencies ?

I noticed this general issue because of a bug with outdated puppeteer..
This is a known issue which is fixed in puppeteer v12 puppeteer/puppeteer#7455
I noticed puppeteer version is 6.0.0, which was release on 2021... and is quite outdated.
Is there any reason why the version is not updated?
I could maybe try and contribute it myself if there are no objections...

Thanks

@yanivfranco yanivfranco changed the title Puppeteer version Puppeteer version & other dependencies versions & security vulnerabilities Jun 7, 2024
@yanivfranco yanivfranco changed the title Puppeteer version & other dependencies versions & security vulnerabilities Dependencies versions & security vulnerabilities Jun 7, 2024
@baruchiro
Copy link
Collaborator

I have no objections, please try.

@yanivfranco
Copy link
Contributor Author

yanivfranco commented Jun 10, 2024

@baruchiro I have a PR ready to be pushed, just need the right permissions.... 🙏
before:
before

after:
after

@baruchiro
Copy link
Collaborator

Hi, if it is your first time contributing on Github, you need to fork this repository and open a pull request from your fork to ours.

Read more here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

If you need any help please ask me.

@yanivfranco
Copy link
Contributor Author

@baruchiro #862

Copy link

Issue has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 20, 2024
@baruchiro
Copy link
Collaborator

Done by #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants