Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bank pagi scraper #880

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat: add bank pagi scraper #880

merged 4 commits into from
Sep 30, 2024

Conversation

Avrhamwales
Copy link
Contributor

Adding a scraper for Bank Pagi (a bank from the Bank Beinleumi Group).
Adding tests or Bank Pagi scraper.

Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eshaham @esakal @erikash Please take a look to verify he is not missing something.

Regarding the version, do you think it introduces a breaking change for TypeScript consumers who built an object based on the Enum?

I think so, but I think it is not enough for a Major version 😉

@Avrhamwales Avrhamwales requested a review from baruchiro August 18, 2024 13:49
@baruchiro baruchiro changed the title Add bank pagi scraper feat: add bank pagi scraper Aug 20, 2024
@baruchiro baruchiro merged commit cbbf9b7 into eshaham:master Sep 30, 2024
6 checks passed
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants