feat: allow to reuse a browser by passing a browserContext

[daniel-hauser]

Motivation:

• Enables efficient scraping of multiple accounts in parallel by allowing to reuse a browser.
• Enables parallel runs of the same scraper with different users by creating a browser context for each user.

Changes:

• Modified the page creation logic to allow passing a browserContext instead of a browser.
• The ScraperOptions interface now has a union of three BrowserOptions interfaces:
  • DefaultBrowserOptions for when the scraper creates the browser.
  • ExternalBrowserOptions for when the caller supplies an external single-use browser.
    • An optional skipCloseBrowser flag was added to allow the caller to manage the browser lifecycle.
  • ExternalBrowserContextOptions for when the caller supplies a BrowserContext and manages the browser lifecycle.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

src/scrapers/base-scraper-with-browser.ts:85

• [nitpick] The word 'bang' might be confusing. It would be clearer to use 'exclamation mark (!)' instead.

NOTICE - it is discouraged to use bang (!) in general.

src/scrapers/base-isracard-amex.ts:33

• The ExtendedScraperOptions interface was removed, but there was no mention of its removal in the context provided. Ensure that this interface is not used elsewhere in the codebase.

type CompanyServiceOptions = {

src/scrapers/base-isracard-amex.ts:258

• [nitpick] The parameter name 'options' is of type 'CompanyServiceOptions'. It would be clearer to rename it to 'companyServiceOptions'.

async function getExtraScrapTransaction(page: Page, options:CompanyServiceOptions, month: Moment, accountIndex: number, transaction: Transaction): Promise<Transaction> {

[daniel-hauser]

@baruchiro Thanks for approving! Do you have an estimation for the merging of the PR?

[github-actions]

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀