Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beinleumi): allow scraping older transactions #896

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

whatuserever
Copy link
Contributor

@whatuserever whatuserever commented Jan 19, 2025

Beinleumi allows retrieving data from 1600 😂
image

Any earlier than that and it fails:
image

Mitigates #894 for Beinleumi

Test

Set startDate in .tests-config.js to 5 years ago and ran tests:

 PASS  src/scrapers/beinleumi.test.ts (35.25 s)

beinleumi.csv output file had transactions going all the way back

@baruchiro
Copy link
Collaborator

Let me understand it... If you set this earlier date, is it really returning your five-years-old transactions?

I want to be sure it actually retrieves the data.

@whatuserever
Copy link
Contributor Author

My account is about 3 years old, so I can't test too far back (definitely not to 1600 😂).

But yes, it does return all of my account's data, and there's no issue with specifying a date before the account's creation.

@baruchiro baruchiro merged commit 80fdf49 into eshaham:master Feb 2, 2025
7 checks passed
Copy link

github-actions bot commented Feb 2, 2025

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants