Visa Cal wrong day of transaction, and missing fields

[baruchiro]

Fixes #781 (I hope)

• Date need to be formatted to ISO date, fixed for processedDate.
• Reorder fields just to be aligned with the previous version of Cal.
• Added field: chargedCurrency.

[baruchiro]

@erikash @daniel-hauser Please review to help @eshaham / @esakal to approve it ASAP :-)

[github-actions]

🎉 This PR is included in version 3.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[erikash]

Sorry just saw it..
LGTM.
Only issue is :
memo: transaction.transTypeCommentDetails.toString() || undefined
now is:
memo: transaction.transTypeCommentDetails.toString()

This means memo could be an empty string and should probably be undefined instead but it's not critical I guess...

[baruchiro]

@erikash I know, but I think in the old scraper it was an empty string and not undefined... And I first want to move back to the old format without breaking changes, to see if we implemented it correctly.

[erikash]

Got it ✌️

…

On Tue, 2 May 2023 at 16:02 Baruch Odem (Rothkoff) ***@***.***> wrote: @erikash <https://github.com/erikash> I know, but I think in the old scraper it was an empty string and not undefined... And I first want to move back to the old format without breaking changes, to see if we implemented it correctly. — Reply to this email directly, view it on GitHub <#783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCIPLX22LGVULUKOWLMM3XEEAU3ANCNFSM6AAAAAAXQ6HX5A> . You are receiving this because you were mentioned.Message ID: ***@***.***>