fix: exported / referenced plugin same instance #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, it’s a bit odd that flat configs allows a redeclaration of a plugin but only if that plugin is Creates odd expectations. |
|
Had to do a workaround for it in neostandard: neostandard/neostandard@26b472b And have still had people ask to add it plugins as peer dependencies instead again: neostandard/neostandard#184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that the exported plugin reference and the one used in the exported configs are the very same – else one will get an error like:
This since two plugins are only allowed to have the same key if they are
===to one another. See: https://github.com/eslint/eslint/blob/0583c87c720afe0b9aef5367b1a0a77923eefe9d/lib/config/flat-config-schema.js#L373-L375This caused a regression for me in https://github.com/voxpelli/eslint-config/blob/638bbad2580bc4246527a6f0d989dc8194547475/base-configs/node.js#L10