Change Request: switch to PR title for default commit message #17555
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
infrastructure
Relates to the tools used in the ESLint development process
ESLint version
main
What problem do you want to solve?
Currently, when there's only one commit on the PR, default commit message presented when merging a pull request with squash is the message of that commit.
Therefore, in such cases (when there's only one commit), if the format of the message is incorrect, we ask the contributor to update the commit message. Sometimes we fix the message manually while merging, which is error-prone because there's no validation at that point. Sometimes we update a technically valid message to better describe the change, which is again error-prone because there's no validation.
What do you think is the correct solution?
GitHub now provides options to always default to the PR title:
The proposal is to switch to "Default to pull request title and commit details".
That would simplify the process for everyone - whenever we need to change the message, we just update the PR title and let the bot validate it.
Participation
Additional comments
Tasks would be to update the bot to always check the PR title, and then update settings in all repositories.
The text was updated successfully, but these errors were encountered: