Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error text illegible due to red too dark #57

Closed
1 task done
adamlui opened this issue Nov 11, 2024 · 1 comment
Closed
1 task done

Bug: Error text illegible due to red too dark #57

adamlui opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working repro:needed This issue should include a reproducible example

Comments

@adamlui
Copy link

adamlui commented Nov 11, 2024

Environment

ESLint version: v9.14.0
@eslint/json version: v0.6.0
Node version: v22.9.0
npm version: v10.9.0
Operating System: Win10

Which language are you using?

json

What did you do?

Configuration
import js from '@eslint/js'
import globals from 'globals'
import json from '@eslint/json'

export default [
    js.configs.recommended,
    { ignores: ['**/*.min.js', '**/sandbox/*'] },
    {
        rules: {
            'indent': 'off', 'no-unexpected-multiline': 'off', 'key-spacing': 'off', // allow whitespace anywhere
            'quotes': ['error', 'single', { 'allowTemplateLiterals': true }], // enforce single quotes except backticks to avoid escaping quotes
            'comma-dangle': ['error', 'never'], // enforce no trailing commas in arrays or objects
            'no-async-promise-executor': 'off', // allow promise executor functions to be async (to accomodate await lines)
            'no-constant-condition': 'off', // allow constant conditions
            'no-empty': 'off', // allow empty blocks
            'no-inner-declarations': 'off', // allow function declarations anywhere
            'no-useless-escape': 'off', // allow all escape chars cause ESLint sucks at detecting truly useless ones
            'no-unused-vars': ['error', { 'caughtErrors': 'none' }] // allow unused named args in catch blocks
        },
        languageOptions: {
            ecmaVersion: 'latest', sourceType: 'script',
            globals: { ...globals.browser, ...globals.node }
        }
    },
    { files: ['**/*.mjs'], languageOptions: { sourceType: 'module' }},
    { files: ['**/*.json'], ignores: ['**/package-lock.json'], language: 'json/json', ...json.configs.recommended }
]
{
  "name": "generate-ip",
  "version": "2.4.3",
  "description": "Randomly generate, format, and validate IPv4 + IPv6 + MAC addresses.",
  "author": {
    "name": "Adam Lui",
    "email": "[email protected]",
    "url": "https://github.com/adamlui"
  },
  "homepage": "https://generate-ip.org",
  "license": "MIT",
  "funding": [
    {
      "type": "github",
      "url": "http://github.com/sponsors/adamlui"
    },
    {
      "type": "ko-fi",
      "url": "https://ko-fi.com/adamlui"
    }
  ],
  "main": "dist/generate-ip.min.js",
  "files": [
    "docs"
  ],
  "directories": {
    "bin": "./bin",
    "lib": "./dist",
    "doc": "./docs"
  },
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "build": "bash utils/build.sh",
    "bump:patch": "bash utils/bump.sh patch",
    "bump:minor": "bash utils/bump.sh minor",
    "bump:major": "bash utils/bump.sh major",
    "publish:patch": "bash utils/bump.sh patch --publish",
    "publish:minor": "bash utils/bump.sh minor --publish",
    "publish:major": "bash utils/bump.sh major --publish"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/adamlui/js-utils.git"
  },
  "keywords": [
    "ip",
    "generator",
    "unique",
    "generate",
    "api",
    "cli",
    "address",
    "ipv4",
    "ipv6",
    "mac"
  ],
  "bugs": {
    "url": "https://js-utils.org/issues"
  },
  "devDependencies": {
    "@adamlui/minify.js": "^1.8.5"
  }
}

What did you expect to happen?

Readable colors on errors

What actually happened?

Image

Link to Minimal Reproducible Example

https://github.com/adamlui/js-utils

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

I had an eye surgery so squinting makes me nauseous, I don't recall JS lint logs being so hard to read though

@adamlui adamlui added bug Something isn't working repro:needed This issue should include a reproducible example labels Nov 11, 2024
@fasttime fasttime added this to Triage Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 12, 2024
@fasttime fasttime removed the status in Triage Nov 12, 2024
@fasttime fasttime moved this to Needs Triage in Triage Nov 12, 2024
@nzakas
Copy link
Member

nzakas commented Nov 12, 2024

This is just a plugin and does not affect the output of ESLint, and ESLint itself also doesn't control this color. It's your terminal settings that determine which color is used for what type of output.

My guess is that your terminal outputs errors in this dark red for some reason, because ESLint is crashing and reporting the error you mentioned in:
#56

@nzakas nzakas closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repro:needed This issue should include a reproducible example
Projects
Archived in project
Development

No branches or pull requests

2 participants