Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v45 - nested dependency overrides have changed #101

Closed
mashaal opened this issue Aug 24, 2021 · 2 comments
Closed

v45 - nested dependency overrides have changed #101

mashaal opened this issue Aug 24, 2021 · 2 comments

Comments

@mashaal
Copy link
Contributor

mashaal commented Aug 24, 2021

When specifying a dep query, the dep seems to only effect the first level of imports?

Example:
https://esm.sh/[email protected] -- which imports this file... v45

This file is correctly dep'd, but it includes an import (first import of the file) to https://cdn.esm.sh/v45/[email protected]/es2021/use-location.js -- which does not have its react dep overwritten /v45/[email protected]/es2021/react.js

This seems to have changed from 44 to 45, as I have a local self hosted instance of 44 running. Here is the example, and the imports seem to be resolved correctly here... v44

@ije
Copy link
Member

ije commented Aug 25, 2021

@mashaal thanks, i will fix this asap! v45 has cancel bundling for internal modules of a package, you can use ?bundle as a workaround.

@ije ije mentioned this issue Aug 27, 2021
6 tasks
@ije ije closed this as completed in 07fb089 Aug 28, 2021
@ije
Copy link
Member

ije commented Aug 29, 2021

@mashaal fixed in v46, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants