New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Fix (storage/fs_local) file path portability bug #158

Merged

ije merged 1 commit into esm-dev:master from rivy-go:fix.fs_local

Sep 20, 2021

Contributor

rivy commented Sep 19, 2021 •

edited

Loading

This PR fixes a Windows file path portability error...

C> go run main.go --port=8080 --dev
...
2021/09/19 12:17:43 [fatal] init storage(fs,local:C:\Users\Roy\go\src\github.com\alephjs\esm.sh\.dev/storage): CreateFile /C:\Users\Roy\go\src\github.com\alephjs\esm.sh\.dev/storage: The filename, directory name, or volume label syntax is incorrect.


          Fix (storage/fs_local) file path portability bug

34e5a00

rivy changed the title ~~Fix (storage/fs_local) file path portability bug~~ 🛠️ Fix (storage/fs_local) file path portability bug

Member

ije commented Sep 20, 2021

lgtm, thanks 🙏

ije merged commit 6d35c20 into esm-dev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet