Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polyfill): add module (fixes #107) #164

Merged
merged 1 commit into from
Sep 21, 2021
Merged

feat(polyfill): add module (fixes #107) #164

merged 1 commit into from
Sep 21, 2021

Conversation

talentlessguy
Copy link
Contributor

this PR adds module to a list of std/node polyfills

closes #107

@talentlessguy talentlessguy self-assigned this Sep 21, 2021
@ije
Copy link
Member

ije commented Sep 21, 2021

lgtm, thanks @talentlessguy

@ije ije merged commit c8be405 into master Sep 21, 2021
@ije
Copy link
Member

ije commented Sep 21, 2021

can you please add some testings for #107 and #163 ?

@ije
Copy link
Member

ije commented Sep 21, 2021

or i will add later

@ije
Copy link
Member

ije commented Sep 21, 2021

https://github.com/alephjs/esm.sh/tree/master/test/deno/common

@talentlessguy talentlessguy deleted the add-module branch September 21, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@talentlessguy talentlessguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsupported-nodejs-builtin-module trying to import WindiCSS/helpers
2 participants
@talentlessguy @ije