Failed to import - cloudinary

[aiotter]

Failing module

• GitHub: https://github.com/cloudinary/cloudinary_npm
• npm: https://www.npmjs.com/package/cloudinary

import * as cloudinary from "https://esm.sh/[email protected]?no-check";

Error message

After running deno run I got this:

Download https://esm.sh/[email protected]?no-check
Uncaught TypeError: Cannot read properties of undefined (reading 'split')
    at https://cdn.esm.sh/v63/[email protected]/deno/cloudinary.js:16:24037
    at https://cdn.esm.sh/v63/[email protected]/deno/cloudinary.js:2:2780
    at https://cdn.esm.sh/v63/[email protected]/deno/cloudinary.js:16:24210

Additional info

• esm.sh version: v63
• Deno version: 1.17.2

When I tried to import it without ?no-check flag, the following error occurred:

error: TS2671 [ERROR]: Cannot augment module 'cloudinary' because it resolves to a non-module entity.
declare module 'cloudinary' {
               ~~~~~~~~~~~~
    at https://cdn.esm.sh/v63/[email protected]/types/index.d.ts:4:16

After import "https://deno.land/[email protected]/node/global.ts", process.versions.node.split(".") itself works successfully.
There seems to be a bug in node.js compartible layer in esm.sh.

[ije]

@aiotter thanks i will look into it

[ije]

after added process.versions.node i got anther error:

[ije]

types seems to work for me:

[aiotter]

Nice, it was so quick! Thanks ☺️

[aiotter]

@ije It seems not working on both esm.sh and localhost yet.

esm.sh:

> import "https://esm.sh/v64/cloudinary"
Uncaught Error: Dynamic require of "proxy-agent" is not supported
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:2:2751
    at Object.Qd [as optionalRequire] (https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:13:3076)
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:14:312
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:2:2831
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:16:20836
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:2:2831
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:16:24193
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:2:2831
    at https://cdn.esm.sh/v64/[email protected]/deno/cloudinary.js:16:24210

localhost (10c10b9):

> import "http://localhost:8080/cloudinary"
Uncaught Error: Dynamic require of "proxy-agent" is not supported
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:2:2751
    at Object.Qd [as optionalRequire] (http://localhost:8080/v64/[email protected]/deno/cloudinary.js:13:3076)
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:14:312
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:2:2831
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:16:20836
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:2:2831
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:16:24193
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:2:2831
    at http://localhost:8080/v64/[email protected]/deno/cloudinary.js:16:24210

[aiotter]

@ije This is just a gentle reminder, but did you checked my report above? If this is a solvable problem on the esm.sh side, can you please reopen the issue?

[ije]

i think i can not fix it, since esbuild rewrite the require function.
but i guess you can add a workaround for it:

import proxyAgent from "https://esm.sh/proxy-agent"
globalThis.require = (name) => {
  if (name == "proxy-agent") return proxyAgent
}

import "https://esm.sh/v64/cloudinary"

[ije]

same as #257

[aiotter]

Thank you for workaround! I appreciate it 😂