feat(build): prevent submodules bundling their local dependencies #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a submodule, esm.sh tries to bundle all its local dependencies. If a local module has its 'inner state', it may occur some errors.
For example, here's a pkgA
The source code in
lib/acc.js
is something likeThe source code in
lib/print.js
is something likeSo after building the
lib/print.js
submodule, thelib/acc.js
's source code will be included.When a third party package (pkgB) importing pkgA,
It actually uses two
pkgA/lib/acc.js
modules -- an original submodule and a copy inpkgA/lib/print.js
. Theidx
variable is not shared.the relative issue #353