Depended module incorrect redirect when use deps option

[Justinidlerz]

Failing module

react-dom / graphQL

import Loading from 'https://esm.sh/[email protected]/es2022/AntdExtends/Loading?bundle&deps=react@18,react-dom@18';

import errorLink from 'https://esm.sh/@apollo/[email protected]/link/error?bundle&deps=react@18,react-dom@18'

The module will load this module:

https://esm.sh/[email protected]/X-ZC9yZWFjdEAxOC4yLjA/es2022/react-dom.js

Since the service upgrade to V100, failed to load some dependencies when setting the deps option for the module.

The correct URL must includes /v100: https://esm.sh/v100/[email protected]/X-ZC9yZWFjdEAxOC4yLjA/es2022/react-dom.js

Error message

After onload I got this:

throw new Error("[esm.sh] " + "parseCJSModuleExports: Package path ./X-ZC9yZWFjdEAxOC4yLjA/es2022/react-dom is not exported from package /tmp/esm-build-cc60c8eed435100cff08af96cf604ff44c4d6cee-9189bf32/node_modules/react-dom (see exports field in /tmp/esm-build-cc60c8eed435100cff08af96cf604ff44c4d6cee-9189bf32/node_modules/react-dom/package.json)");
export default null;

Additional info

• esm.sh version: v100
• Browser version: *

[PeterBLITZ]

The error is present in other packages, even without any options.

e.g., https://esm.sh/[email protected]/es2022/crypto-browserify.js

[ije]

https://esm.sh/[email protected]/es2022/crypto-browserify.js

this url is not correct (missing /v100 prefix), where you got it?

[ije]

import Loading from 'https://esm.sh/[email protected]/es2022/AntdExtends/Loading?bundle&deps=react@18,react-dom@18';

this you need to remove es2022 part

[Justinidlerz]

But es2022 is the server adds, I just only do this on my code:

https://esm.sh/aftership-sdui-library/AntdExtends/Loading?bundle&deps=react@18,react-dom@18

And that works on previous versions' servers, we do not modify any codes

[ije]

i see, will look into it. thanks!

[Justinidlerz]

Wow, what is this tool? looks so cool, could you share it with me?

[ije]

Wow, what is this tool? looks so cool, could you share it with me?

by deno info command

[ije]

i found the bug, will deploy to prod after testing

[Justinidlerz]

Hello @ije, The react-dom is back to normal, but graphql still failed

[ije]

it's cached, i need to release v101 to fix this, please wait

[Justinidlerz]

Okay, thanks

[PeterBLITZ]

https://esm.sh/[email protected]/es2022/crypto-browserify.js

this url is not correct (missing /v100 prefix), where you got it?

I have a URL like this: https://esm.sh/v100/[email protected]/es2022/crypto-browserify.bundle.js, but inside, you can find incorrect relative import import br from"/[email protected]/es2022/events.bundle.js"; without /v100 prefix.

Unlike v99 https://esm.sh/v99/[email protected]/es2022/crypto-browserify.bundle.js, where we can find relative imports with prefix import __events$ from "/v99/[email protected]/es2022/events.bundle.js";

[ije]

@PeterBLITZ i believe v101 fixed this issue

[PeterBLITZ]

@PeterBLITZ i believe v101 fixed this issue

Yup. Thank you)