-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use export =
in TypeScript declaration files
#485
Comments
thanks! i will look into it. |
@dsherret should we rename |
It should represent the transformed esm code, so I think |
The testing is failed after resolving |
rename |
This diagnostic has now landed in TypeScript 5.0. |
This is going to start erroring in Deno 2.0 in order to align with TypeScript as it doesn't make sense for an esm module to have a common js |
thnaks @dsherret i will look into it! |
It should be warning now in the latest RC. It might start erroring sometime in the future, but I'm not sure how feasible that is to do. |
TypeScript may start raising a diagnostic when ESM declaration files use
export =
. This will cause issues for esm.sh. For example: https://esm.sh/@types/[email protected]/index.d.ts serves up a declaration file that hasexport = santize
in it. I thinkexport =
needs to be moved away from.See microsoft/TypeScript#51321 (comment) for more details.
The text was updated successfully, but these errors were encountered: