Typings not being loaded for "dedent" NPM package

[heyajulia]

Failing module

• GitHub: https://github.com/dmnd/dedent
• npm: https://www.npmjs.com/package/dedent

import dedent from "https://esm.sh/v113/[email protected]";

Error message

There's no error message per se, but typings are not loaded, so the function typed as any when I mouse over it in Visual Studio Code (even though typings are available). As a workaround, I'm using https://cdn.skypack.dev/[email protected]?dts, which does work as expected.

Additional info

• esm.sh version: 113 (I think)
• Deno version:

deno 1.32.0 (release, x86_64-unknown-linux-gnu)
v8 11.2.214.9
typescript 5.0.2

[echoptic]

having the same issue with dayjs. when importing from 'npm:' the types work.

import dayjs from "https://esm.sh/v113/[email protected]";
import relativeTime from "https://esm.sh/v113/[email protected]/plugin/relativeTime.js";

dayjs.extend(relativeTime);

  // @ts-ignore Deno doesn't recognize the function fromNow
  const ago = dayjs(props.time * 1000).fromNow();

[ije]

@heyajulia but seems there is no types defined in the package.json

[ije]

@echoptic this is known issue, because currently the dts transformer can handle module extend well

// esm.sh ignores below types
declare module 'dayjs' {
  interface Dayjs {
    fromNow(withoutSuffix?: boolean): string
    from(compared: ConfigType, withoutSuffix?: boolean): string
    toNow(withoutSuffix?: boolean): string
    to(compared: ConfigType, withoutSuffix?: boolean): string
  }
}

i will fix it later

[echoptic]

@ije I'm interested in helping somehow if possible. Is there a related issue open for this?

[heyajulia]

@heyajulia but seems there is no types defined in the package.json

I see that's true; I did not know that was a requirement. I'm guessing Skypack tries to look for (and finds) @types/dedent in that case, and esm.sh doesn't.

[ije]

I'm guessing Skypack tries to look for (and finds) @types/dedent in that case, and esm.sh doesn't.

@types/dedent doesn't define the types field neither, but should use index.d.ts instead. i will fix!

[ije]

@ije I'm interested in helping somehow if possible. Is there a related issue open for this?

@echoptic can you please open another issue we can discuss? thanks

[echoptic]

@ije oppened #581