-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexplained esbuild error #77
Comments
@jaydenseric thanks, i will look into it. |
@ije what was the unexpected |
Another clue; importing the same thing via the package index instead of a deep import appears to work: - import waterfallRender from "https://esm.sh/[email protected]/public/waterfallRender.js";
+ import { waterfallRender } from "https://esm.sh/[email protected]/public/index.mjs"; We need deep imports to work though. |
Getting desperate, so many packages I depend on have the same error. Here's another example: |
I will fix it asap! |
fixed in |
I'm struggling to figure out what the problem is with this URL:
https://esm.sh/[email protected]/public/waterfallRender.js?target=deno
It result in a HTTP 500 status:
Is this code not compatible with esm.sh, or is this a bug with the service? There isn't an obvious bundling error, as that package actually has a passing
esbuild
bundle test:https://github.com/jaydenseric/react-waterfall-render/blob/fcbcb036f136a0c28d5ec551556ebac25040355d/test/bundle.test.mjs#L7-L26
I've tried the test with a bunch of
esbuild
versions (all passing) in case the esm.sh service hasn't deployed the latest one yet:https://github.com/postui/esm.sh/blob/e65ba3e5cbccd27c9ad20f2817594830c121ae76/go.mod#L6
Skypack seems to deal with it fine:
https://cdn.skypack.dev/[email protected]/public/waterfallRender.js
Although it results in a runtime error that
process
is undefined, because skypack apparently doesn't doprocess.env.NODE_ENV
based code elimination by default, which thereact/jsx-runtime
dependency contains:https://unpkg.com/[email protected]/jsx-runtime.js
Here is the source in case something jumps out as being incompatible with esm.sh:
https://github.com/jaydenseric/react-waterfall-render/blob/v2.0.0/public/waterfallRender.js
The text was updated successfully, but these errors were encountered: