Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed a Jquery Once() replacement in Key name Provider overview for Drupal 10 #297

Closed
DiegoPino opened this issue Feb 6, 2024 · 2 comments
Closed

Missed a Jquery Once() replacement in Key name Provider overview for Drupal 10 #297

DiegoPino opened this issue Feb 6, 2024 · 2 comments
Labels
bug Something isn't working Drupal 10 Upgrade Economy (capitalism) Javascript Property Keys Providers Drupal plugins that harvest the possible keys that will be exposed to the rest of Drupal UI/UX Experience
Milestone
1.3.0

Comments

@DiegoPino
Copy link
Member

What?

/admin/structure/strawberry_keynameprovider/overview uses Ajax/JS and I missed replacing a legacy jQuery Once with the new Drupal once() API.

Fixing it. Will make a 1.3 and 1.4 fix
@DiegoPino DiegoPino added bug Something isn't working Property Keys Providers Drupal plugins that harvest the possible keys that will be exposed to the rest of Drupal UI/UX Experience Drupal 10 Upgrade Economy (capitalism) Javascript labels Feb 6, 2024
@DiegoPino DiegoPino added this to the 1.3.0 milestone Feb 6, 2024
@DiegoPino
Copy link
Member Author

@alliomeria this is what we experienced together today when I tried to show you how this whole thing could be better. So tagging you :)

This was referenced Feb 6, 2024
Merged
Merged
@DiegoPino DiegoPino changed the title Missied a Jquery Once() replacement in Key name Provider overview for Drupal 10 Missed a Jquery Once() replacement in Key name Provider overview for Drupal 10 Feb 6, 2024
@DiegoPino
Copy link
Member Author

Resolved via 12dbc38
and 8a31b80

Thanks for watching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Drupal 10 Upgrade Economy (capitalism) Javascript Property Keys Providers Drupal plugins that harvest the possible keys that will be exposed to the rest of Drupal UI/UX Experience
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@DiegoPino