Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic IABookreader Search Controller misbehaves when a CWS Child uses it directly #305

Closed
DiegoPino opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request Search API F around and find out Strawberry Flavor Post Processing data extracted that goes into Solr Typed Data and Search UI/UX Experience Working Group's 💜 Imagined, curated and loved by the Working Group
Milestone

Comments

@DiegoPino
Copy link
Member

What?

Because our most basic Flavor driven Search Controller for OCR is unaware of IIIF Manifests (and we have now the Search API enabled endpoints that are really smart), when a CWS child has a IABookreader attached directly and e.g has a PDF, the Page used to return the results is swapped for the relative to the parent Sequence ID, making all results appear on the same page.

This controller was always meant to deal with the simplest use cases. All media of a normal ADO being displayed (e.g a single PDF) or each CWS child being a single page.

The fix (very specific for this use case) is simple but won't resolve the issue of e.g a CWS IIIF Manifest with complex multi page per CWS child data being displayed at the top level Object, so really a definitive fix requires

  • IIIF Search API that we use for Mirador to be used *config option + JS * also on IABookreader
  • Make also Mirador react to the same URI #fragments that book reader accepts so Mirador can be used as a direct swap replacement of IA Book reader

Once question I have for you @alliomeria is:

  • If I detect that e.g the results are coming from multiple children and some are already PDFs (means book reader won't be able to handle the search) should I basically abort highlighting and return a message saying we can't search? Or have a way that IABookreader for those use cases basically cancels even the search at all before we expose it? I kinda feel giving people wrong highlights is worst that not even enabling them ... what are your feelings about that?
@DiegoPino DiegoPino added bug Something isn't working enhancement New feature or request Typed Data and Search Strawberry Flavor Post Processing data extracted that goes into Solr UI/UX Experience Search API F around and find out labels Feb 16, 2024
@DiegoPino DiegoPino self-assigned this Feb 16, 2024
@DiegoPino DiegoPino added the Working Group's 💜 Imagined, curated and loved by the Working Group label Feb 16, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Feb 16, 2024
@DiegoPino
Copy link
Member Author

Resolved via 4a8a450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Search API F around and find out Strawberry Flavor Post Processing data extracted that goes into Solr Typed Data and Search UI/UX Experience Working Group's 💜 Imagined, curated and loved by the Working Group
Projects
None yet
Development

No branches or pull requests

1 participant