Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilizing CpuClock #2663

Closed
MabezDev opened this issue Dec 2, 2024 · 2 comments · Fixed by #2899
Closed

Stabilizing CpuClock #2663

MabezDev opened this issue Dec 2, 2024 · 2 comments · Fixed by #2899
Assignees
Milestone

Comments

@MabezDev
Copy link
Member

MabezDev commented Dec 2, 2024

As part of #2499

We're discussing how to stabilize the minimum amount. Or whether this should be stabilized at all.

Stabilize default and max

For each chip we only stabilize the lowest and highest clock speed, and expose default and max methods.

Stabilize CpuClock as is?

Whilst this enum covers every chip we currently support, could run into an issue with future chips, mostly around dynamic frequencies - if a future chip supports that. Given that it's a new chip, we can introduce a different API for this, so I don't see this being an issue.

Don't stabilize it

This option is quite self explanatory, we just mark it as #[unstable], and in esp_hal::Config and come back to stabilize this at a later date. Clock setting is only really required for use with esp-wifi, which itself is currently unstable.

@MabezDev MabezDev added RFC Request for comment 1.0-blocker labels Dec 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Dec 2, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 3, 2024

I vote for Stabilize CpuClock as is

@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 16, 2024
@MabezDev
Copy link
Member Author

MabezDev commented Jan 7, 2025

Let's stabilize this as is. We can mark it as #[non_exaustive] and relax it later on, as we're doing with the clock source enums.

@MabezDev MabezDev removed RFC Request for comment investigation Not needed for 1.0, but don't know if we can support without breaking the driver. labels Jan 7, 2025
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 7, 2025
@bjoernQ bjoernQ self-assigned this Jan 7, 2025
@bjoernQ bjoernQ linked a pull request Jan 7, 2025 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants