Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-INTERMEDIATE #2784

Closed
Tracked by #2493
bugadani opened this issue Dec 13, 2024 · 2 comments
Closed
Tracked by #2493

C-INTERMEDIATE #2784

bugadani opened this issue Dec 13, 2024 · 2 comments
Labels

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 13, 2024

  • Should write, read, write_read return the number of transmitted/received bytes on error?
  • Should transaction return the number of successfully completed operations?
@MabezDev
Copy link
Member

MabezDev commented Jan 7, 2025

Should write, read, write_read return the number of transmitted/received bytes on error?

I'm not sure it's that useful. The read & write API will read/write until the buffer is full/empty - unless an error occurs, in which case the buffer state is unknown (and I'm not sure a partial filled buffer is even useful).

Should transaction return the number of successfully completed operations?

This seems more useful, and might allow the user to continue the transaction in some cases if the user know where the transaction failed - it might also be helpful for debugging.

@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 7, 2025
@MabezDev MabezDev removed the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Jan 7, 2025
@MabezDev MabezDev removed this from the 1.0.0-beta.0 milestone Jan 10, 2025
@MabezDev
Copy link
Member

Closing this in favour of the general one: #2820, it expands a bit more on the idea above.

@MabezDev MabezDev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants