Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI: Expose timing delays #2801

Open
Tracked by #2494
bjoernQ opened this issue Dec 13, 2024 · 3 comments
Open
Tracked by #2494

SPI: Expose timing delays #2801

bjoernQ opened this issue Dec 13, 2024 · 3 comments
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:spi SPI peripheral

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 13, 2024

MISO dummy delay
dummy delay
These are derived from a number of input params, including the expected bus speed etc so we need to take that into account.

@bjoernQ bjoernQ changed the title Expose timing delays SPI: Expose timing delays Dec 13, 2024
@tom-borcin tom-borcin added investigation Not needed for 1.0, but don't know if we can support without breaking the driver. 1.0-blocker and removed 1.0-blocker labels Dec 16, 2024
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 15, 2025

I'm not sure what this issue is asking for? SPI_DINx_MODE, SPI_DINx_NUM and SPI_DOUTx_MODE?

@Dominaezzz
Copy link
Collaborator

That's what it sounds like to me.

@bugadani
Copy link
Contributor

bugadani commented Jan 17, 2025

Indeed this issue sounds like it's about "Timing Compensation" (ESP32-S3 TRM (v1.6) 30.8, or ESP32 TRM (v5.2) 7.4.2, for example)

I believe this should be a backwards compatible config addition. We should be careful, because ESP32 may need different values depending on DMA and Mode, but if we make the configuration Optional, we can let the driver choose for the user if nothing is given, but make it the user's responsibility to provide values that work if they need to.

I'll mark this as a done+non-blocker, and we can reset if this solution ends up inadequate in a way that requires breaking the API.

@bugadani bugadani added 1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. investigation:done and removed 1.0-blocker investigation Not needed for 1.0, but don't know if we can support without breaking the driver. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:spi SPI peripheral
Projects
Status: Todo
Development

No branches or pull requests

5 participants