Virtual functions in client.h are out of line with standard Arduino API #2755

SRGDamia1 · 2019-05-07T19:45:27Z

Hardware:

Board: ESP32
Core Installation version: 1.0.2
IDE name: PlatformIO
Flash Frequency: N/A
PSRAM enabled: N/A
Upload Speed: N/A
Computer OS: Linux (TravisCI)

Description:

I am working on TinyGSM - a cross-platform GSM client. Because the client.h file in the current ESP32 core does not match the standard Arduino API (https://github.com/arduino/ArduinoCore-API/blob/master/api/Client.h) the library can no longer be compiled by esp32 users.

NOTE: The ESP8266 core introduced the same problem in version 2.5.0. They are fixing it for 2.5.1 (esp8266/Arduino#5969)

Sketch: (leave the backquotes for code formatting)

#include <Arduino.h>

#define TINY_GSM_MODEM_SIM800
#include <TinyGsmClient.h>

void setup() {
}

void loop() {
}

Debug Messages:

Unable to compile because of undefined virtual functions:

/tmp/tmpgkfUuk/src/test_build.ino:11:15: error: cannot declare variable 'client' to be of abstract type 'TinyGsmA6::GsmClient'
TinyGsmClient client(modem);
^
In file included from lib/TinyGSM/src/TinyGsmClient.h:65:0,
from /tmp/tmpgkfUuk/src/test_build.ino:8:
lib/TinyGSM/src/TinyGsmClientA6.h:44:7: note:   because the following virtual functions are pure within 'TinyGsmA6::GsmClient':
class GsmClient : public Client
^
In file included from /home/travis/.platformio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:157:0,
from /tmp/tmpdTm4GS:1:
/home/travis/.platformio/packages/framework-arduinoespressif32/cores/esp32/Client.h:31:17: note: 	virtual int Client::connect(IPAddress, uint16_t, int)
virtual int connect(IPAddress ip, uint16_t port, int timeout) =0;
^
/home/travis/.platformio/packages/framework-arduinoespressif32/cores/esp32/Client.h:32:17: note: 	virtual int Client::connect(const char*, uint16_t, int)
virtual int connect(const char *host, uint16_t port, int timeout) =0;
^

This was also mentioned in #2704.

The text was updated successfully, but these errors were encountered:

jozala · 2019-05-14T18:55:46Z

I've got the same problem. After downgrading to 1.0.1 it works again.

thujer · 2019-05-15T09:43:30Z

Hardware

Board: WeMos WiFi and Bluetooth Battery
Platform: Espressif 32
Configuration: ESP32 240MHz 320KB RAM (4MB Flash)
IDE: VSCode 1.33.1
OS: Linux / XUbuntu

Description

We are working on multi communication device (Wifi, Ethernet, RS232, Bluetooth). Last week we cannot compile source codes, because there is some errors in Ethernet library, described bellow.

I tried to compile some basic Arduino examples (WebClient) in Arduino IDE and I got same resolution.

In file included from src/EthernetController/EthernetController.h:5:0,
from src/App/App.h:11,
from src/App/App.cpp:2:
.piolibdeps/Ethernet_ID872/src/Ethernet.h:258:2: error: invalid abstract return type 'EthernetClient'
EthernetClient available();
^
.piolibdeps/Ethernet_ID872/src/Ethernet.h:214:7: note:   because the following virtual functions are pure within 'EthernetClient':
class EthernetClient : public Client {
^

This was also mentioned in Arduino Libraries Issues
arduino-libraries/Ethernet#97

misak113 · 2019-05-23T13:59:51Z

We're dealing with the exactly same issue. Could you please, please 👍 look at it? :)

digitalwm · 2019-05-26T08:12:45Z

Same issue here.

brentru · 2019-05-30T13:47:27Z

Same issue with ArduinoHTTPClient and Adafruit IO Arduino, @me-no-dev will this change be reverted in a future 1.0.3 release similar to what happened with the Arduino ESP8266 core.

thujer · 2019-06-10T17:33:31Z

We fixed this incompatibility by downgrading Espressif32 platform core from 1.8.0 to 1.7.0.

Just put line bellow into platformio.ini

platform = [email protected]

If some other libraries was updated and some errors will be show, then try downgrade libraries by the same way or put the old libraries code directly into the project directory and update #include directives.

Good Luck

Hardware

Board: WeMos WiFi and Bluetooth Battery
Platform: Espressif 32
Configuration: ESP32 240MHz 320KB RAM (4MB Flash)
IDE: VSCode 1.33.1
OS: Linux / XUbuntu

Description

We are working on multi communication device (Wifi, Ethernet, RS232, Bluetooth). Last week we cannot compile source codes, because there is some errors in Ethernet library, described bellow.

I tried to compile some basic Arduino examples (WebClient) in Arduino IDE and I got same resolution.
In file included from src/EthernetController/EthernetController.h:5:0,
from src/App/App.h:11,
from src/App/App.cpp:2:
.piolibdeps/Ethernet_ID872/src/Ethernet.h:258:2: error: invalid abstract return type 'EthernetClient'
EthernetClient available();
^
.piolibdeps/Ethernet_ID872/src/Ethernet.h:214:7: note:   because the following virtual functions are pure within 'EthernetClient':
class EthernetClient : public Client {
^
This was also mentioned in Arduino Libraries Issues
arduino-libraries/Ethernet#97

brentru · 2019-06-10T17:37:34Z

@thujer Yep, you can downgrade to retain the old feature. Point is - the function signatures should be in-line with the Arduino API in a new release of the ESP32 BSP.

brentru · 2019-06-13T20:26:47Z

@me-no-dev Any updates on this?

This is required to make Ethernet library compile (see espressif/arduino-esp32#2755)

eabase · 2019-07-19T15:08:41Z

Hi Guys!
Why not try to fix this? It just doesn't make sense to have to downgrade, since who knows what other crazy 2ndary bugs would get (re)introduced by doing such a thing.

We're also trying to implement an IoT solution that require an updated library when using TinyGSM, so it would be a bloody shame to have to abandon 2 libraries (and perhaps even more) just because this one won't play ball. Especially since several other things already depend on this.

I hope you can reconsider and prioritize this issue.

Cheers,
👍

xvinny-zz · 2019-08-12T22:04:24Z

I had to implement my own HttpClient (it is very simple, with support only for GET). Like @eabase said, why don't you prioritize this issue? It is simple to solve and it would help a lot of users!!

brentru · 2019-08-12T22:15:46Z

@me-no-dev Any updates on this issue?

hardmax · 2019-08-30T00:12:27Z

Hi,

ArduinoHttpClient library has the same problem, please review to correct this..are a lot a libraries with problems

kugelkopf123 · 2019-09-08T23:28:43Z

The Problem still exists with 1.0.3-rc3

me-no-dev · 2019-09-09T06:38:51Z

Sorry guys! I get hundreds of emails daily and it's not possible to read them all. Please, stop by gitter (link in the readme) and drop a message if something is seriously wrong. I try to keep an eye there. Issue is fixed and will be in 1.0.3 final.

xvinny-zz · 2019-09-18T17:41:44Z

@SRGDamia1 the 1.0.3 final update was released!!!

brentru · 2019-09-18T17:54:24Z

1.0.3 works with Adafruit IO Arduino and Adafruit MQTT, thanks @me-no-dev.

SRGDamia1 · 2019-09-18T18:47:39Z

Thanks!

per1234 · 2024-12-17T06:47:55Z

There was a regression of this bug in #10202

Examples of breakage caused:

Library compilation fails with "esp32" boards platform version 3.1.0 arduino-libraries/ArduinoHttpClient#182
Compilation error when using PlatformIO and Ethernet.h arduino-libraries/Ethernet#277

pennam · 2024-12-17T07:33:29Z

It breaks also arduino-libraries/ArduinoMqttClient#112

SRGDamia1 mentioned this issue May 7, 2019

During comilation example WebClient.ino on ESP32 got error "cannot declare variable 'client' to be of abstract type 'TinyGsmSim800::GsmClient' vshymanskyy/TinyGSM#269

Closed

JAndrassy mentioned this issue May 14, 2019

compilation error with ESP32 DIV Kit arduino-libraries/Ethernet#97

Closed

This was referenced May 23, 2019

Problem with Ethernet.h compilation after board library update from 1.0.1 to 1.0.2 #2786

Closed

HTTPClient.h and ArduinoHttpClient.h side by side vshymanskyy/TinyGSM#283

Closed

PuceBaboon mentioned this issue May 24, 2019

It does not compile PuceBaboon/ESP32_W5500_GW#1

Open

This was referenced May 30, 2019

Issue with ArduinoHttpClient and WiFi/WiFiClientSecure #2839

Closed

Connection refused using HTTPClient.h vshymanskyy/TinyGSM#281

Closed

brentru mentioned this issue May 31, 2019

ESP32 Possible Bug ( maybe similar to ESP8266 issue) adafruit/Adafruit_IO_Documentation#2

Closed

jozala added a commit to jozala/ESP32_W5500_MQTT that referenced this issue Jun 20, 2019

Specifying espressif32 platform version explicitely

7e3f38b

This is required to make Ethernet library compile (see espressif/arduino-esp32#2755)

SRGDamia1 mentioned this issue Jun 24, 2019

esp32 compile error: "cannot declare variable 'http' to be of abstract type 'HttpClient' " vshymanskyy/TinyGSM#306

Closed

atanisoft mentioned this issue Jul 18, 2019

HAL read/peek timeout with native freeRTOS blocking mechanism #3004

Closed

SRGDamia1 mentioned this issue Jul 19, 2019

Trial to port Freematics SIM5360 to TinyGSM vshymanskyy/TinyGSM#189

Closed

jozala mentioned this issue Jul 27, 2019

Incorrect TCP packets when using W5500 with ESP32 arduino-libraries/Ethernet#106

Open

wolfen351 mentioned this issue Aug 1, 2019

I'm working to add Simcom SIM5320 Support vshymanskyy/TinyGSM#313

Closed

per1234 mentioned this issue Aug 13, 2019

Fixing compatibility for usage with ESP32 core arduino-libraries/ArduinoMqttClient#9

Closed

me-no-dev mentioned this issue Sep 9, 2019

Remove extra connects from Client.h #3191

Merged

me-no-dev closed this as completed in #3191 Sep 9, 2019

orvisevans mentioned this issue Dec 31, 2019

WebServer and ASyncWebServer do not work with Ethernet #3580

Closed

per1234 mentioned this issue Dec 19, 2024

Compilation error when using PlatformIO and Ethernet.h arduino-libraries/Ethernet#277

Open

MicSG-dev mentioned this issue Dec 20, 2024

Compilation error when using PlatformIO and Ethernet.h #10760

Closed

1 task

pennam mentioned this issue Dec 23, 2024

Restore Arduino Client API #10776

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtual functions in client.h are out of line with standard Arduino API #2755

Virtual functions in client.h are out of line with standard Arduino API #2755

SRGDamia1 commented May 7, 2019

jozala commented May 14, 2019

thujer commented May 15, 2019 •

edited

Loading

misak113 commented May 23, 2019

digitalwm commented May 26, 2019

brentru commented May 30, 2019 •

edited

Loading

thujer commented Jun 10, 2019

Hardware

Description

brentru commented Jun 10, 2019

brentru commented Jun 13, 2019

eabase commented Jul 19, 2019

xvinny-zz commented Aug 12, 2019

brentru commented Aug 12, 2019

hardmax commented Aug 30, 2019

kugelkopf123 commented Sep 8, 2019

me-no-dev commented Sep 9, 2019

xvinny-zz commented Sep 18, 2019

brentru commented Sep 18, 2019

SRGDamia1 commented Sep 18, 2019

per1234 commented Dec 17, 2024 •

edited

Loading

pennam commented Dec 17, 2024

Virtual functions in client.h are out of line with standard Arduino API #2755

Virtual functions in client.h are out of line with standard Arduino API #2755

Comments

SRGDamia1 commented May 7, 2019

Hardware:

Description:

Sketch: (leave the backquotes for code formatting)

Debug Messages:

jozala commented May 14, 2019

thujer commented May 15, 2019 • edited Loading

Hardware

Description

misak113 commented May 23, 2019

digitalwm commented May 26, 2019

brentru commented May 30, 2019 • edited Loading

thujer commented Jun 10, 2019

Hardware

Description

brentru commented Jun 10, 2019

brentru commented Jun 13, 2019

eabase commented Jul 19, 2019

xvinny-zz commented Aug 12, 2019

brentru commented Aug 12, 2019

hardmax commented Aug 30, 2019

kugelkopf123 commented Sep 8, 2019

me-no-dev commented Sep 9, 2019

xvinny-zz commented Sep 18, 2019

brentru commented Sep 18, 2019

SRGDamia1 commented Sep 18, 2019

per1234 commented Dec 17, 2024 • edited Loading

pennam commented Dec 17, 2024

thujer commented May 15, 2019 •

edited

Loading

brentru commented May 30, 2019 •

edited

Loading

per1234 commented Dec 17, 2024 •

edited

Loading