Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc/ssi_psram): Add octal psram (QEMU-231) #112

Closed

Conversation

Throows
Copy link

@Throows Throows commented Dec 30, 2024

Description

This MR add the octal PSRAM for the ESP32S3

Related

Feature for the #109 issue.

Testing

Just run the simple hello world program from esp-idf (V5.3.2)

Without octal ram you can launch QEMU with the command :

./qemu-system-xtensa \
        -machine esp32s3 \
        -nographic \
        -s -S \
        -drive file=merged-binary.bin,if=mtd,format=raw \
        -m 8M

With octal PSRAM you can launch QEMU with the command :

./qemu-system-xtensa \
        -machine esp32s3 \
        -nographic \
        -s -S \
        -drive file=merged-binary.bin,if=mtd,format=raw \
        -m 16M \
        -global driver=ssi_psram,property=is_octal,value=true

NOTA BENE: I removed the possibility to configure the dummy. its now handled automatically by the software... is it a good idea ? (Introcuced bug with esp32)

Best regards, Romain

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions github-actions bot changed the title feat(misc/ssi_psram): Add octal psram feat(misc/ssi_psram): Add octal psram (QEMU-231) Dec 30, 2024
@Throows Throows force-pushed the feature/octal_psram_esp32s3 branch from 03ea9ff to 01f092b Compare December 31, 2024 09:51
hw/misc/ssi_psram.c Outdated Show resolved Hide resolved
@Throows Throows force-pushed the feature/octal_psram_esp32s3 branch from 01f092b to ac2ee50 Compare December 31, 2024 12:22
@o-marshmallow o-marshmallow self-assigned this Jan 13, 2025
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA and removed Status: To Do labels Jan 14, 2025
@igrr
Copy link
Member

igrr commented Jan 18, 2025

Cherry-picked with a small fixup in 48b3fa9, thanks @Throows!

@igrr igrr closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants