Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for configuring WatchProgressNotifyInterval in integration tests #12265

Closed
wojtek-t opened this issue Sep 2, 2020 · 2 comments · Fixed by #12271
Closed

Allow for configuring WatchProgressNotifyInterval in integration tests #12265

wojtek-t opened this issue Sep 2, 2020 · 2 comments · Fixed by #12271
Assignees

Comments

@wojtek-t
Copy link
Contributor

wojtek-t commented Sep 2, 2020

I'm working on utlizing progress-notify feature in Kubernetes as part of https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption

I have it working already in my branch and working on extending tests. Unfortunately, the existing etcd integration server doesn't allow for configuring that now.

The ask is to allow setting that at the level of integration.ClusterConfig:

type ClusterConfig struct {

and pipe it down to etcdserver.ServerConfig so that we can utlize it in tests (ideally also cherrypick it back to 3.4 branch).

@jingyih @jpbetz

@jingyih
Copy link
Contributor

jingyih commented Sep 3, 2020

I can help with this. @wojtek-t

@wojtek-t
Copy link
Contributor Author

wojtek-t commented Sep 9, 2020

@jingyih - can you please cherrypick to 3.4 (I'm not able to reopen to track the cherrypick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants