Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linearizable renew lease configurable #18100

Closed
aaronjzhang opened this issue May 30, 2024 · 1 comment
Closed

Make linearizable renew lease configurable #18100

aaronjzhang opened this issue May 30, 2024 · 1 comment
Labels
type/feature

Comments

@aaronjzhang
Copy link

aaronjzhang commented May 30, 2024 •
edited
Loading

What would you like to be added?

Add a config flag to make linearizable renew lease configurable.

Why is this needed?

The feature "linearizable renew lease" has a side affect, when "apply entries took too long" happens and the apply time took more than the TTL of a lease will cause lease keep alive failure, for some applications, they can tolerate the fake lease keep alive failure, in this case, they just need to grant a new lease and retry, but they can't tolerate the "apply entries took too long" blocks the keep alive for all leases.
@ahrtr
Copy link
Member

ahrtr commented May 30, 2024

It may break correctness, so there is no plan to support this. See also #18091 (reply in thread)

@ahrtr ahrtr closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronjzhang @ahrtr