Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-processing in BaseX testdriver #93

Closed
jonherrmann opened this issue May 7, 2020 · 2 comments
Closed

Pre-processing in BaseX testdriver #93

jonherrmann opened this issue May 7, 2020 · 2 comments
Assignees
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Milestone

Comments

@jonherrmann
Copy link
Contributor

jonherrmann commented May 7, 2020

ETF Improvement Proposal (EIP)

Background and Motivation:

In some cases it may be necessary to prepare the input data either by transforming the input or by ensuring that the data meets certain requirements.

A concrete use case is the sorting out of features with invalid geometries.

Proposed change

To achieve the greatest possible flexibility, it should be possible to implement the preprocessing step in XQuery. The test driver should execute the preprocessing step if an XQuery file 'prepare-chunk.xq' is found in the ETS project directory. It will be executed on every chunk before data is added to the database. The test driver provides XQ-interfaces to mark invalid test data in a file.

The docs.etf-validator.org developer documentation should point to the interface documentation in the test driver repository.

Alternatives

none

Funding

yes

Additional information

Technical details:

mark invalid test data in a file means that the specific node is not inserted into the database but moved to a separate, isolated database. This allows to remove Features with invalid geometries from further tests but with the option to access data from the feature e.g. collecting and outputting their gml IDs.

@jonherrmann jonherrmann added the EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. label May 7, 2020
@jonherrmann jonherrmann self-assigned this May 7, 2020
@jonherrmann jonherrmann added EIP Improvement Proposal. Put up for discussion. and removed EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. labels Jun 15, 2020
@jonherrmann jonherrmann changed the title Preprocessing in BaseX testdriver [DRAFT] Pre-processing in BaseX testdriver Jun 15, 2020
@cportele cportele added EIP-approved EIP approved by the Steering Group and removed EIP Improvement Proposal. Put up for discussion. labels Jun 16, 2020
@cportele
Copy link
Contributor

Approved in SG meeting 23

@jonherrmann jonherrmann added the Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label) label May 23, 2022
@jonherrmann
Copy link
Contributor Author

Implemented in Version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Projects
None yet
Development

No branches or pull requests

2 participants