-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Suggestion and Testing #4
Comments
for discord is it this link? https://cdn.discordapp.com/attachments/* |
Heavily guessing here, but maybe the file has a delay on being updated to the servers?
Even if catbox is banned in your country, pretty sure that Google's servers are in not in the countries that have strict internet censorship. IIRC, the servers are in US, EU, and SG. catbox links are
I think having a special case for websites would be a bad idea and will lead to code bloat, I propose that having a toggle of downloading from anywhere would faster to implement (also easier?). But regardless, these are the sites that provide direct links to files that I can list at the top of my head:
|
wget etc. doesn't work on catbox even on colab, i tried. Maybe i'll try again with vpn. |
@NUROISEA try this branch
i added aria2 downloader, discord attachment, changed os.system to subprocess, more accurate logging system, controlnet path, and github extension clone. I'll merge to main if it's stable enough. Still uncertain about the other websites. Maybe you can give me model link examples for every website?😊 Imma sleep for now. It's midnight on my timezone🌃 |
Console output
|
Console output
|
Console output
|
Sorry, i think the extension update breaks everything. You can git checkout to the previous commit (on the same branch). I'm currently not in my house, I'll check that later. |
Try this one
|
@NUROISEA whoops sorry, wrong command. Here's the one:
|
okay, i noticed the same problem also happens on that commit. I know the problem and will fix it soon |
@NUROISEA sorry for the inconvenience🙏, i pushed a new commit.
It fixes most of the bugs, all downloader working, extension texted, haven't tested discord attachment yet. Thank you by the way, for debugging my previous code, really appreciated😁✨ Currently i'm planning to update it once more before merging to main. Someone give me codes to directly download from civitai model page link, instead of from civitai direct link.😊 |
Hi @etherealxx, I tested your branch against the latest version of the webui and against my fork (previous versions of the webui) and I saw no problems with your extension! Test case:
Tested with all 4 download methods Test environment (a colab I quickly wrote for this purpose) Test limitations:
|
Thank you!😊✨ So i'll try to implement that on the next commit. Also that person commented about the UI. I wanna hear from you what do you think about the UI honestly. I try to make it as easy-for-beginner as possible (as i was months ago). |
Yo, let's go!
The UI is intuitive, at a glance you kinda know what you are dealing with already, so no problems on the UI side of things. :D |
hello @NUROISEA 👋 After hours of staring at codes, finally i pushed this (almost) final commit. Here's the list of all new features you can test it with this:
i tested most of it works (haven't tested Windows yet). If it's stable enough, i'll merge it with main. (I'll also ask some of my friend on discord to test it too i think)😊 |
Hi @etherealxx! here's my testing: Inputs:
Results:
Civitai seems to fail on both methods on aria2, direct Civitai error log:
Another bug I saw is the output box seems to not display anything after finishing the task, successful or not. Granted, I am not using |
Thank you so much for the findings!🤗✨ that error log is actually comes from the debug text i made for, well, debugging purposes.
should be like this
Also yeah, i haven't tested this on non queue environment and the old version, i might check that. More bug fixing to come🛠️🪲🏃♂️💨💨 |
hi @NUROISEA , it's been a while😅
I tested it on camenduru's v2.0. Also with gradio queue on, as queue off might breaks some things. (camen's colab is queue on by default anyway) I also has this version that was built solely for camenduru's v1.6 colab. (won't work properly on others)
this one seems to be an issue with timeout and websocket (i didn't quite understand that), but to mitigate that problem, this 'onedotsix' variant will cut the download session every 2 minutes, and there will be a resume button to resume the cutted download session. Just wanna say thank you for your support all this time, really means a lot to me🙏✨ |
Hi hello @etherealxx o/ I'm quite short in time so I only tested your extension on a 1 month old commit of the webui since I figured there's no major changes between this and the latest version of the webui anyway 😄 Alas the test went smooth, no problems whatsoever! Tested with Input
All links work on all download methods, even catbox! Test limitation is I didn't test the raw github links since I cannot find TIs or anything that is hosted in github. Since stuff works flawlessly, I'll just suggest things. These can be done on a later date, whenever you feel like it 😆
Notice the
You did well on this 👏👏👏 I added your extension earlier on my colab collection, so kinda so it's being battle tested right now 😄 |
Thank you! Since this is stable enough, i'll do some tweak then push straight away! (it's been pain in the ass holding the update long enough😅) Then i'll start adding more features.
Will do! forgot about that😅
This one is kinda hard. If i remove the
While i really like customization, it might get more confusing, as this hashtag syntaxing thing is, while designed to be really beginner friendly, i can see some people still getting confused to it. I would, figure out some stuff to allow easier way to renaming things.
Let's say it's complicated right now (#43 #26 #146). Again, I'll add it if i figured things out.
Lastly, thank you so much 🙏✨ Couldn't thank you enough. |
Hello @NUROISEA , long time no see😊 For the past couple weeks i've been developing on the next update of this extension. Some of the feature are the one that you requested: renaming and google drive support. In fact, the rename function already available since weeks ago i think😅
for current version that i'm developing, it's aiming to support more and more website. Currently: This update will also use different method for downloading civitai from direct links, speeding up the download speed by up to 40x (looks comical but the current method can sometimes goes really slow like 5Mbps). Also there's a lot going on in the backround, related to how civitai model page link is downloaded (takes a lot of my time to fix it 🙃) Another feature i'm implementing is called 'sdless', where you can run the extension without even launching the sd-webui (more here). It makes my developing progress much quicker! (though, this is the toughest update since i'm still learning things 😅) Next feature that someone suggested is custom hashtag with custom path. Works something like this
Another qol feature is Lastly, the UI got updated a bit, and that's it. if you want to test it:
I might spend another day or two to write some stuff on the readme page, and then release the update straight away. I would like to reach you in discord if you have one, so we can talk or something👀. Or maybe just join camenduru's server since i'm there too.✨ |
Hi @etherealxx! Cool update! I have tested the extension with the latest A1111 commit with the same text file as my previous comments and there are some bugs, unfortunately:
Do note that my test is limited since I have limited time and do not have the proper links to the new sites but I would assume that they work, catbox in an exception since I am getting unlucky with the servers and I cannot download from that site. This is it for my bug reports. (sorry if this feels quite lazy I'm also doing something and I'm just testing on my downtime 😅) I tried breaking your extension, by mixing up the hashtags, a simplified example would be:
and it would just download it correctly to the appropriate places! The rename feature is such a nifty QoL one, thank you for that. The custom path works as intended too! I haven't tested I like what you have done to the UI, hiding stuff and stretching the UI seems pretty nifty (although stretched looks dank on wide resolutions 😂) Overall, good job on this one! Seems pretty solid by the looks of it! 🎉 And yes I do have discord, I'll just DM you with this screenshot of this response in the editor. I think you can verify if you try to edit this. |
Okay, time to address the problem.
i don't know how to replicate it, honestly. Can you give me the example/links where it happens?
It's supposed to be orange, gradio's color. But i think the auto1111's code messed it up. When i launch the UI standalone-ly, the progress bar works fine.
so the thing is, the way gradio works is an UI change only could happen by a return value passed into the components. I want it so that after the download is finished, the table become automatically updated, so that when ppl use custom hashtag, it will shows after the download is finished right away. (i can't update the UI while the code is running, unless it use
I do test all of them, but you seem have a skill to somehow breaks my extension sometimes, and that's useful😆
Don't worry! I'm not forcing you at all. I'm just asking for a little help in your spare time😋 don't feel burdened, consider it a little activity when there is nothing to do.
yeah i made it bcoz one of the link i downloaded from pixeldrain is a .7z file. Would be very handy coz the syntax for extracting a simple single item is pretty long. I'll add .zip and .rar support too i guess...
The reason i haven't got rid that useless huge Again, thank you for spending your time on this passion project of mine, really really appreciated😊 |
The update is now live! Thank you for every of your previous supports on this project!💖✨ Release note (every new feature): https://github.com/etherealxx/batchlinks-webui#release-v301 |
A lot of embeddings and loras are uploaded to catbox.moe and related sites from users on 4ch.
Maybe an edge case, I tend to store my TIs in Discord since its quite convenient.
Since this extension is already utilizing
gdown
, downloading from Google Drive also?Maybe add this as a toggleable option since supporting every site will lead to unexpected things.
The text was updated successfully, but these errors were encountered: