Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(host): Split CLI utilities out from binary #169

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Apr 28, 2024

Overview

Splits the CLI utilities outside of the main binary in preparation for various versions of the host binary. This allows us to re-use the existing CLI structure without cross-dependencies between binary entrypoints.

Copy link
Collaborator Author

clabby commented Apr 28, 2024

@clabby clabby added K-chore Kind: chore A-host Area: host binary labels Apr 28, 2024
@clabby clabby requested a review from N0xMare April 28, 2024 19:48
@refcell
Copy link
Collaborator

refcell commented Apr 28, 2024

Not super opinionated here - binary modularization is less important than published crates. Let's iterate fast to unblock any host work.

Copy link
Contributor

@N0xMare N0xMare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean ;)

## Overview

Splits the CLI utilities outside of the main binary in preparation for
various versions of the host binary. This allows us to re-use the
existing CLI structure without cross-dependencies between binary
entrypoints.
@clabby clabby changed the base branch from cl/bin-just-directives to main April 28, 2024 20:18
@clabby clabby enabled auto-merge April 28, 2024 20:18
@clabby clabby added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit 2f242f1 Apr 28, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
@clabby clabby deleted the cl/host-modes branch July 2, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants