Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mpt): Do not expose recursion vars #197

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore(mpt): Do not expose recursion vars #197

merged 1 commit into from
Jun 4, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 1, 2024

Overview

Hides the recursive variable in TrieNode::insert and TrieNode::open

@clabby clabby mentioned this pull request Jun 1, 2024
Merged
@clabby Graphite App
Copy link
Collaborator Author

clabby commented Jun 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Jun 1, 2024
Merged
@clabby clabby force-pushed the cl/hide-recursive-params branch from 846b8a5 to 5573789 Compare June 1, 2024 01:51
@clabby clabby marked this pull request as draft June 1, 2024 01:55
@clabby clabby self-assigned this Jun 1, 2024
@clabby clabby added K-chore Kind: chore A-mpt Area: kona-mpt crate labels Jun 1, 2024
@clabby clabby mentioned this pull request Jun 1, 2024
Merged
@clabby clabby force-pushed the cl/trie-db-commit branch from 3e11d2e to d6c8369 Compare June 1, 2024 22:05
@clabby clabby force-pushed the cl/hide-recursive-params branch from 5573789 to 92f9394 Compare June 1, 2024 22:05
@clabby clabby marked this pull request as ready for review June 1, 2024 22:06
@clabby clabby force-pushed the cl/hide-recursive-params branch from 92f9394 to 2901cba Compare June 1, 2024 22:09
@clabby clabby force-pushed the cl/trie-db-commit branch from d6c8369 to 557784b Compare June 1, 2024 22:27
@clabby clabby force-pushed the cl/hide-recursive-params branch from 2901cba to 3dbcf50 Compare June 1, 2024 22:27
@clabby clabby mentioned this pull request Jun 2, 2024
Merged
@clabby clabby requested a review from refcell June 2, 2024 05:53
@clabby clabby force-pushed the cl/trie-db-commit branch from 557784b to 3169166 Compare June 3, 2024 22:50
@clabby clabby force-pushed the cl/hide-recursive-params branch from 3dbcf50 to c349b63 Compare June 3, 2024 22:50
@clabby clabby force-pushed the cl/trie-db-commit branch from 3169166 to 9dd36ee Compare June 3, 2024 22:56
@clabby clabby force-pushed the cl/hide-recursive-params branch from c349b63 to 9ff3949 Compare June 3, 2024 22:56
refcell
refcell approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor ✅

Base automatically changed from cl/trie-db-commit to main June 4, 2024 15:12
@clabby
chore(mpt): Do not expose recursion vars
ff35886 
Hides the recursive variable in `TrieNode::insert` and `TrieNode::open`
@clabby clabby force-pushed the cl/hide-recursive-params branch from 9ff3949 to ff35886 Compare June 4, 2024 15:12
@clabby clabby enabled auto-merge June 4, 2024 15:13
@clabby clabby added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 7e4d948 Jun 4, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Closed
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 11, 2024
This was referenced Jun 11, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
@clabby clabby deleted the cl/hide-recursive-params branch July 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-mpt Area: kona-mpt crate K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell