feat(derive): Add ecrecover trait + features
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove `custom-ecrecover` feature
clabby
force-pushed
the
cl/ecrecover-handler
branch
from
1f7392b to
9087a7b
Compare
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new trait,
SignedRecoverable, which represents the functionality for recovering a public key from a signed type that has access to the message hash.With the
k256feature enabled, a default implementation of this trait is implemented onTxEnvelopefromalloy-consensus. This feature can be disabled to allow for a custom secp256k1 recovery method. This will be used in the program to facilitate an accelerator for signature recovery during verification through the host program.If the
k256feature is not enabled, and there is no implementation of theSignedRecoverableextension trait onTxEnvelope, thekona-derivecrate will fail to compile.