Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov for Go Tests #12999

Closed
tynes opened this issue Nov 20, 2024 · 0 comments · Fixed by #13062
Closed

Fix Codecov for Go Tests #12999

tynes opened this issue Nov 20, 2024 · 0 comments · Fixed by #13062
Assignees

Comments

@tynes
Copy link
Contributor

tynes commented Nov 20, 2024

All of the Go unit tests should be uploading results to codecov so that we can make sure that code we are modifying is covered with tests. This will help with dev velocity if we integrate it into our daily workflow. Right now only cannon tests are included in codecov, you can see here: https://app.codecov.io/github/ethereum-optimism/optimism/tree/develop.

The codecov config file seems to be out of date: https://github.com/ethereum-optimism/optimism/blob/f2056c031ece39c681fa3e9e3690b958faf029fd/codecov.yml

The update needs to be made around here:

gotestsum --format=testname \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants