Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect naming for eip-micropayments_standard_for_nfts_and_multi_tokens.md. #4614

Closed
mryalamanchi opened this issue Dec 29, 2021 · 4 comments
Closed

Incorrect naming for eip-micropayments_standard_for_nfts_and_multi_tokens.md. #4614

mryalamanchi opened this issue Dec 29, 2021 · 4 comments

Comments

@mryalamanchi
Copy link
Contributor

APMU, the EIPs are to be numbered and not contain the EIP title.
This EIP's filename has deviated from the common practice
and has also generated a deviated link eip-micropayments_standard_for_nfts_and_multi_tokens

Should this be handled the same way eip-20-token-standard.md -> eip-20 was handled?
@MicahZoltu
Copy link
Contributor

Hmm, I'm surprised the bot allowed that to be merged. PR to rename it would be very much appreciated! Feel free to mention me on such a PR. No need to do any complicated migration as the EIP is just a draft and only recently merged.

@mryalamanchi
Copy link
Contributor Author

Alright! Will just rename the EIP now and later check with the bot issue.

@MicahZoltu MicahZoltu mentioned this issue Jan 1, 2022
Closed
@mryalamanchi mryalamanchi mentioned this issue Jan 1, 2022
Merged
@mryalamanchi
Copy link
Contributor Author

mryalamanchi commented Jan 1, 2022 •
edited
Loading

Done!
PR: #4619

@MicahZoltu
Copy link
Contributor

Related: ethereum/eipv#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MicahZoltu @mryalamanchi