Make EIPs Website a PWA

[Pandapip1]

Proposed Change

This will allow for offline viewing of EIPs just by visiting the EIPs website. I volunteer to implement this.

[SamWilsn]

I'm concerned about caching because I don't understand PWAs. Is that something I should be worried about?

[Pandapip1]

I'm concerned about caching because I don't understand PWAs. Is that something I should be worried about?

Basically, you can implement bespoke caching rules. The one I'd implement is "stale while revalidate": Send the cached version immediately (if available) but update the cache in the background.

[lightclient]

I don't think this is an important use case and so it doesn't warrant more code that needs to be maintained. Unless I misunderstand the scope and this is only a few lines change. IMO a much bigger value add would just be improving the look of the EIPs website.

[Pandapip1]

Unless I misunderstand the scope and this is only a few lines change.

It'll be about 30 lines of pretty understandable code (including comments).

[xinbenlv]

As much as I like PWA's loading speed improvement, not all search engines deal with PWA very well, so I am on the fence for adopting PWA for EIP site

[Pandapip1]

not all search engines deal with PWA very well

As implemented, it shouldn't impact search engine results. It will just be for browser caching.

[xinbenlv]

Some search engines don't index well PWA pages. E.g. here are a few things from one of the search engine. just to show it's nontrivial. https://developers.google.com/search/blog/2016/11/building-indexable-progressive-web-apps

[Pandapip1]

Some search engines don't index well PWA pages. E.g. here are a few things from one of the search engine. just to show it's nontrivial. https://developers.google.com/search/blog/2016/11/building-indexable-progressive-web-apps

Pretty sure that that particular reference applies more to SPAs. This particular service worker is a glorified cache-control header and does not modify page content.

[xinbenlv]

Sure, if you understand the difference between PWA and SPA, just make sure the static HTTP yields the same or similar full content of text, then I have no concern at all for any PWA.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Still an issue.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

There's a PR open to add this.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Waiting on approval.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Waiting on approval.

[Pandapip1]

This is a comment to dismiss the stale review bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

This is a comment to dismiss the stale review bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

This is a comment to dismiss the stale review bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Would still like this. It doesn't add much complexity, and is really nice to have.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Dismissing bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Dismissing bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

Dismissing bot.

[github-actions]

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

[Pandapip1]

I'll close this. It'll either happen or it won't.