Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize metrics across different client implementations #11

Open
terencechain opened this issue Jul 21, 2020 · 1 comment
Open

Standardize metrics across different client implementations #11

terencechain opened this issue Jul 21, 2020 · 1 comment

Comments

@terencechain
Copy link

It'll be very nice for all the client implementations to converge on a set of metrics for support. The benefits of metrics standardization includes enabling of converged monitoring across difference implementations, better debugging support in multi client testnet, and better instrumentations which can lead to more client side optimizations.
At the minimal, we should converge on the naming first, and the set of baseline metrics to implement second. There will be divergences such a language dependent metrics and that is ok. (eg. goroutines for Golang, JVM thread counts of JAVA... etc)

@paulhauner
Copy link

Great idea!

We have quite a lot of metrics (hundreds?) but I suspect we don't need all of these standardized and I think @terencechain was also expressing this. For reference, these are our "beacon chain" metrics that are most likely to be good standardization targets: https://github.com/sigp/lighthouse/blob/master/beacon_node/beacon_chain/src/metrics.rs. Not all of them are relevant, but perhaps someone might find value in giving them a skim.

I'm not saying we should use the Lighthouse ones, I'm happy to follow suit if someone else already has a set that's more conformant with Prom/Grafana best practices (IIRC, ours diverge at times).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants