Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off "gatsby-plugin-intl" #2777

Closed
samajammin opened this issue Apr 2, 2021 · 3 comments
Closed

Migrate off "gatsby-plugin-intl" #2777

samajammin opened this issue Apr 2, 2021 · 3 comments
Labels
dependencies 📦 Changes related to project dependencies refactor ♻️ Changes which don't affect functionality Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project

Comments

@samajammin
Copy link
Member

Is your feature request related to a problem? Please describe.

During migration to Gatsby v3 (#2528) we've hit warnings that the gatsby-plugin-intl is not compatible with Gatsby v3.

There's an open issue & PR to address this:
wiziple/gatsby-plugin-intl#172

But it appears the project is no longer maintained:
wiziple/gatsby-plugin-intl#168

Describe the solution you'd like

Given all the custom functionality we've already implemented around internationalization (e.g. see our gatsby-node.js file), I think we could remove the plugin entirely & roll our own solution.

I'm keen to explore a solution similar to what we built for the Eth2 launchpad just using react-intl:
ethereum/staking-launchpad#308
Main win here would be to auto-generate string ids so we could keep the English content right in components for easier readability & DX. One thing we'd need to confirm is if Gatsby can be configured to use the defaultMessage approach to auto-generate those string ids. CRA didn't support this out of the box (see formatjs/formatjs#2151).

Describe alternatives you've considered

Looks like there's a fork of gatsby-plugin-intl with Gatsby v3 support:
https://github.com/theowenyoung/gatsby-plugin-intl

@samajammin samajammin added Type: Internal refactor ♻️ Changes which don't affect functionality tooling 🔧 Changes related to tooling of the project labels Apr 2, 2021
@samajammin samajammin changed the title Migrate off gatsby-plugin-intl Migrate off "gatsby-plugin-intl" Apr 2, 2021
@samajammin samajammin added the dependencies 📦 Changes related to project dependencies label Apr 2, 2021
@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 18, 2021
@ethereum ethereum deleted a comment from github-actions bot Aug 5, 2021
@minimalsm minimalsm reopened this Aug 5, 2021
@minimalsm minimalsm removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 5, 2021
@minimalsm
Copy link
Contributor

Codebase would definitely be a lot less intimidating and easier to navigate for newer contributors if there is something we could do here.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 10, 2021
@ethereum ethereum deleted a comment from github-actions bot Oct 11, 2021
@minimalsm minimalsm removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 11, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 26, 2021
@minimalsm
Copy link
Contributor

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Changes related to project dependencies refactor ♻️ Changes which don't affect functionality Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

No branches or pull requests

2 participants