Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Learn section of Navbar #3984

Closed
minimalsm opened this issue Sep 22, 2021 · 19 comments
Closed

Rethink Learn section of Navbar #3984

minimalsm opened this issue Sep 22, 2021 · 19 comments
Assignees
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes help wanted Extra attention is needed or someone is needed to help low priority This has a low priority proposal 🤔 This is a proposal Status: Blocked 🛑 This is blocked Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@minimalsm
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The number of links in the 'Learn' section of the main navigation is outgrowing the initial design.

Screenshot 2021-09-22 at 14 17 06

This looks fine for now but very soon we'll be adding 3-4 new pages. Aesthetically this doesn't look great but also runs into Hick's Law problems - reducing the likelihood users will find the information they are looking for and reducing the user experience.

Screenshot 2021-09-22 at 14 19 25

Describe the solution you'd like

Open to suggestions. Just wanted to highlight this issue.

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

@minimalsm minimalsm added help wanted Extra attention is needed or someone is needed to help design required 🎨 This involves design changes proposal 🤔 This is a proposal low priority This has a low priority labels Sep 22, 2021
@MrBrain295
Copy link
Contributor

Maybe a more button that could show the rest?

@vj-codes
Copy link
Contributor

vj-codes commented Oct 1, 2021

@minimalsm hey can this be a hacktoberfest issue?

@CjFlypuffin369
Copy link

hello

@Vishnurr2k01
Copy link

Vishnurr2k01 commented Oct 2, 2021

adding a scroll ?

@minimalsm
Copy link
Contributor Author

Hey everyone. This issue requires design before being worked on (i.e. if you have a proposal feel free to comment here). Some sort of re-organization of the navbars is probably required for this.

@nikkhielseath
Copy link
Contributor

@minimalsm

I shall like to propose a design inspired by this Nav from Revolut.
image

Especially, those curved borders.

@samajammin
Copy link
Member

Marking this as blocked - I think we should re-think this as part of an overhaul of the learn page more broadly:
https://ethereum.org/en/learn/

My gut take as of now is we can build out a landing page for the Learn section of the site that acts as a hub & provides a hierarchy of topics & subpages, similar to how we have the "Developers' Home" within the "Developers" dropdown menu.

@samajammin samajammin added the bug 🐛 Something isn't working label Nov 16, 2021
@samajammin
Copy link
Member

samajammin commented Nov 16, 2021

Noting this is also a bug on smaller screens/browsers - the dropdown nav is cut off with no ability to scroll:

Screen.Recording.2021-11-16.at.06.23.08.AM.mp4

@minimalsm perhaps a short term fix would be to remove some of these pages from the dropdown? e.g. I think at least these could be removed - they're less important pages & are linked to from the footer & elsewhere:

  • Ethereum Glossary
  • Community guides and resources
  • Ethereum Improvement Proposals

@aguscruiz
Copy link

I have a proposal for the design. Here are my thoughts:

  • The dropdown could be divided into sections, I divided here in the mock but I may not be correct on the division criteria (that's open to discussion obviously).
  • We could only list the "most useful" learn articles at the dropdown, and have a "browse all topics" at the bottom to link to a Learn landing page with every article listed.
  • I added a bit more whitespace to the dropdown items, specially with regards to the dropdown border, it felt too cramped.
  • Also added a subtle drop shadow to elevate the dropdown a bit.

Learn section

image

Another nav dropdown

image

@aguscruiz
Copy link

@minimalsm thoughts?

@samajammin
Copy link
Member

Thanks for the suggestion @aguscruiz! I like your proposal 😄

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 11, 2022
@samajammin samajammin removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 11, 2022
@samajammin
Copy link
Member

Multiple folks have also reported this in Discord:

@maxgeor
Copy link

maxgeor commented Apr 4, 2022

Basic/Advanced

Quick win would be properly grouping and nesting different ideas. Since this tab is about learning, it makes sense to group ideas into Basic and Advanced (people shouldn't read "Blockchain Bridges" before "What's ETH?"). Here's one grouping:

Learn

  • Basics
    • What’s Ethereum?
      • Ether (ETH)
      • Smart contracts
      • History of Ethereum
      • Ethereum upgrades
      • Ethereum Whitepaper
    • DeFI (Decentralized finance)
    • NFTs (Non-fungible tokens)
    • DAOs (Decentralized autonomous organisations)
    • Web3

  • Advanced
    • Ethereum governance
    • Blockchain bridges
    • Ethereum energy consumption
    • Ethereum Improvement Proposals

    • Ethereum security and scam prevention
  • More (this one doesn't need a label)
    • Ethereum glossary
    • Community guides and resources

Then you can lay out the nav horizontally, which each section next to eachother to save on vertical space:

Learn
Basics Advanced More

You can add flex-wrap: wrap to the container so it won't get smushed.

Mobile

The site has a pretty hefty nav overall. For mobile, it makes sense to ditch the typical pop-out list and for a full width/height, global nav modal. It would have 2 columns to save vertical space.

Scrolling Bug

Slapping a min-height using vh units with overflow-scroll should solve the no-scroll issue.

@samajammin
Copy link
Member

Assigning to @konopkja 😄

@DaveyD233

This comment was marked as spam.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 6, 2022
@corwintines
Copy link
Member

@minimalsm @konopkja I imagine this can be closed now.

@samajammin
Copy link
Member

Solved in #6778 - thanks @konopkja & @pettinarip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes help wanted Extra attention is needed or someone is needed to help low priority This has a low priority proposal 🤔 This is a proposal Status: Blocked 🛑 This is blocked Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests