Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suggested Goerli TTD #563

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add Suggested Goerli TTD #563

merged 1 commit into from
Jul 18, 2022

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Jul 17, 2022

What does this do?

Proposes a terminal total difficulty of 10,790,000 for the Goerli merge. To get to this value, I looked at the last ~1m blocks on the network, and estimated the highest/lowest average difficulty increase per block over all 50,000 block windows, as well as the average over the entire set, and used https://ttd.goerli.net/ to sanity check the last 100,000 block average.

Assuming Bellatrix is scheduled for August 4, 2022, this TTD would not be hit before even at the highest rolling average we've seen in the past 1m blocks. Assuming things keep following the current short/medium term averages, we should expect TTD to be hit around August 9-11th, and if the difficulty per block was at its lowest in the past 1m blocks, we'd hit it a few days later, around August 13.

Cute Animal Picture

Screen Shot 2022-07-17 at 10 09 44 AM

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #563 (f3301d0) into master (bb950ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files         333      333           
  Lines       19219    19219           
=======================================
  Hits        14958    14958           
  Misses       4261     4261           
Flag Coverage Δ
unittests 77.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb950ce...f3301d0. Read the comment docs.

@emptymindgit
Copy link

Cute animal pic looks good

Copy link
Contributor

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@taxmeifyoucan
Copy link
Member

I verified this using predict_ttd as with previous testnets and I can confirm the proposed TTD value fits my estimation.
image

@timbeiko timbeiko merged commit b70bc37 into master Jul 18, 2022
ajsutton added a commit to ajsutton/eth2-networks that referenced this pull request Jul 18, 2022
Bellatrx activation epoch 112260 (2022-08-04 12:24 pm UTC, 8:24am NY, 10:24pm Brisbane/Sydney)
TTD 10790000 as per ethereum/execution-specs#563
@parithosh
Copy link
Member

Note to CL client teams, Please ensure that the goerli flag exists as an alias to the prater flag in your releases.

ajsutton added a commit to eth-clients/eth2-networks that referenced this pull request Jul 19, 2022
Bellatrx activation epoch 112260 (2022-08-04 12:24 pm UTC, 8:24am NY, 10:24pm Brisbane/Sydney)
TTD 10790000 as per ethereum/execution-specs#563
@SamWilsn SamWilsn deleted the timbeiko-patch-7 branch April 10, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants