Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dedicated peer slots for light clients #15624

Closed
veox opened this issue Dec 7, 2017 · 5 comments
Closed

Feature: dedicated peer slots for light clients #15624

veox opened this issue Dec 7, 2017 · 5 comments

Comments

@veox
Copy link
Contributor

veox commented Dec 7, 2017

Geth/v1.7.3-stable-4bb3c89d/linux-amd64/go1.9

I've recently spun up a node with the sole intent to serve light clients. In the systemd service file, I've indicated:

--maxpeers 150 --lightserv 90 --lightpeers 135

Of course, This doesn't do what I'd like. My peer list is 85 "light" clients and 65 "regular" ones. I'd like it to be 135/15, respectively.

It "would be nice" to have an option to limit "regular" peers; alternatively, it "would be nice" to be able to reserve peer slots specifically for "light" clients.


EDIT: For ref, this has been implemented in PR #16010.

@veox
Copy link
Contributor Author

veox commented Dec 7, 2017

This doesn't seem particularly difficult, so could submit PR, even if it takes me a while.

This block puts a lower limit on "regular" peers, to be 1/2 of maxpeers.


What would be a reasonable approach and option name?

  • Limit "regular" peers with --maxfullpeers? Or name it --fullpeers? --heavypeers?..
  • Rework --lightpeers to mean "dedicated light client slots"?
  • Allow specifying --minfullpeers?
  • Something else?

@veox veox mentioned this issue Dec 7, 2017
@ligi
Copy link
Member

ligi commented Dec 8, 2017

I've recently spun up a node with the sole intent to serve light clients.

❤️ 👍 🎆 🎉 🎈 💯 🥇

@veox
Copy link
Contributor Author

veox commented Dec 16, 2017

My peer list is 85 "light" clients and 65 "regular" ones.

To clarify: this is 5-15 minutes after node restart.

I've noticed that after a few days of continuous operation at the limit of the system's CPU load capacity, the numbers gravitate towards: less "regular" peers, more light ones.

At some point, though, the node experiences some failure and stops syncing (while still having both types of peers). I'll see what running at increased verbosity gets me.


EDIT: May be same as issue #15636.

@lmars
Copy link
Contributor

lmars commented Dec 16, 2017

I'm having a similar issue whereby I am running a light server but I actually get too many light clients (see #15689), which means I end up with only light peers and no full peers to get new blocks from.

@veox
Copy link
Contributor Author

veox commented Feb 3, 2018

From #15689 (comment), --lightpeers is planned to mean "dedicated light peer connection slots".

Closing this, as it's now a duplicate (sort of).

@veox veox closed this as completed Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants