Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error for go-duktape.v3 with go1.9beta2 on linux #15970

Closed
luoiefly opened this issue Jan 25, 2018 · 3 comments
Closed

build error for go-duktape.v3 with go1.9beta2 on linux #15970

luoiefly opened this issue Jan 25, 2018 · 3 comments

Comments

@luoiefly
Copy link

Hi there,

[luoie@iZ2ze8cv2xzahguq7l3lveZ go-duktape.v3]$
[luoie@iZ2ze8cv2xzahguq7l3lveZ go-duktape.v3]$ go version
go version go1.9beta2 linux/amd64
[luoie@iZ2ze8cv2xzahguq7l3lveZ go-duktape.v3]$ go build

_/home/luoie/blockchain/ethfun/vendor/gopkg.in/olebedev/go-duktape.v3

./duktape.go:132: constant 18446744073709551615 overflows int64
[luoie@iZ2ze8cv2xzahguq7l3lveZ go-duktape.v3]$

@holiman
Copy link
Contributor

holiman commented Jan 25, 2018

This is due to a compiler error in Go 1.9.0 and 1.9.1, update to 1.9.2 instead. See golang/go#21708

@holiman holiman closed this as completed Jan 25, 2018
@Philipp2406
Copy link

I am running Go 1.9.2 and get the following:

`github.com/ethereum/go-ethereum/vendor/gopkg.in/olebedev/go-duktape.v3

github.com/ethereum/go-ethereum/vendor/gopkg.in/olebedev/go-duktape.v3

In file included from vendor/gopkg.in/olebedev/go-duktape.v3/api.go:7:0:
vendor/gopkg.in/olebedev/go-duktape.v3/api.go: In function ‘_duk_error’:
vendor/gopkg.in/olebedev/go-duktape.v3/duktape.h:510:127: warning: right-hand operand of comma expression has no effect [-Wunused-value]
(duk_error_raw((ctx), (duk_errcode_t) (err_code), (const char *) (DUK_FILE_MACRO), (duk_int_t) (DUK_LINE_MACRO), VA_ARGS), (duk_ret_t) 0)

vendor/gopkg.in/olebedev/go-duktape.v3/api.go:153:2: note: in expansion of macro ‘duk_error’
duk_error(ctx, err_code, "%s", str);
^~~~~~~~~
`

@karalabe
Copy link
Member

Yeah, annoying but it's just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants