Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PULL_REQUEST_TEMPLATE.md #20023

Closed
ligi opened this issue Sep 2, 2019 · 2 comments
Closed

add PULL_REQUEST_TEMPLATE.md #20023

ligi opened this issue Sep 2, 2019 · 2 comments
Labels
type:docs

Comments

@ligi
Copy link
Member

ligi commented Sep 2, 2019

currently we do not have a PULL_REQUEST_TEMPLATE.md - we only have a ISSUE_TEMPLATE.md
a PULL_REQUEST_TEMPLATE could be helpful to improve the quality of PR-submissions and the whole PR process in general. E.g. encourage submitters to have tests in their PRs. This template can also point to: https://geth.ethereum.org/developers/Code-Review-Guidelines
@ligi ligi mentioned this issue Sep 2, 2019
Closed
@quinise quinise mentioned this issue Sep 21, 2019
Closed
@ligi
Copy link
Member Author

ligi commented Oct 17, 2019

new link here: https://geth.ethereum.org/docs/developers/code-review-guidelines

@adamschmideg adamschmideg mentioned this issue Nov 5, 2019
Closed
@adamschmideg
Copy link
Contributor

We agreed we don't need a PR template because we assume contributors have already read the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pull request template adamschmideg/go-ethereum
3 participants
@ligi @karalabe @adamschmideg