Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock mechanism flaw mist opens 2 second unlock timout window. #2584

Closed
pat-kim opened this issue May 19, 2016 · 2 comments
Closed

Unlock mechanism flaw mist opens 2 second unlock timout window. #2584

pat-kim opened this issue May 19, 2016 · 2 comments

Comments

@pat-kim
Copy link

pat-kim commented May 19, 2016

Geth version: All verions
OS & Version: All operating systems

Expected behaviour:

From user perspective API call communication between mist and geth scheme does not allow man in middle attack.

Actual behaviour:
Mist calls geth in order to send tx with account unlocking for 2 second. Not likely other wallet singed tx itself and send before sending to the geth this allows man in middle attack via IPC and RPC while making a transaction by mist.

Steps to reproduce the behaviour:
Simple batch script successfully hijack transaction to IPC with default mist and geth settings.
Refer the following video.

https://www.youtube.com/watch?v=PNSwFy__m-8

@pat-kim pat-kim changed the title Unlock mechanism flaw mist opens 2 second unlock timed window. Unlock mechanism flaw mist opens 2 second unlock timout window. May 19, 2016
@bas-vk
Copy link
Member

bas-vk commented May 19, 2016

Addressed in #2564.
Will leave this open to prevent duplicates.

@stale
Copy link

stale bot commented Mar 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:inactive label Mar 5, 2018
@stale stale bot closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants