Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum node panic. #29860

Closed
NathanHo1024 opened this issue May 28, 2024 · 7 comments · Fixed by #29864
Closed

ethereum node panic. #29860

NathanHo1024 opened this issue May 28, 2024 · 7 comments · Fixed by #29864
Assignees

Comments

@NathanHo1024
Copy link

hi. sir. i got a panic in my ethereum node. i wonder what's happen? the ethereum docker version : ethereum/client-go:latest . image id : 651587b0bf93
Uploading image.png…

@rjl493456442
Copy link
Member

Could you please provide the panic log? Your image is not resolved.

@NathanHo1024
Copy link
Author

Could you please provide the panic log? Your image is not resolved.
ok,

panic: moveToList("fast" - "slow"): node 524d07ba7d306c095c933d942982d9ae8c629e89548faae7d5e24a5801958cc not in source list
goroutine 24755 [running]
github. com/ethereum/go-ethereum/p2p/discover.(*tableRevalidation). moveToList(0x1a882817, 0xc01b6a4128, Oxc01b6a40f0, 0xc0390e76d0, 0x9c86701b3cd53,
{0x2011f20, 0xc01b6a40b0})
github.com/ethereum/go-ethereum/p2p/discover/table_reval.go:174 +0x16e
github.com/ethereum/go-ethereum/p2p/discover.(*tableRevalidation). handleResponse(0xc016a40f0, 0xc01b6a4008, {0xc039076d0?, 0x07, Oxc01b6a40f0?,
17})
github.com/ethereum/go-ethereum/p2p/discover/table_reval.go:158 +0x465
github. com/ethereum/go-ethereum/p2p/discover.(*Table).loop(0xc01b6a4008)
github. com/ethereum/go-ethereum/p2p/discover/table.go:376 +0x72d
created by github.com/ethereum/go-ethereum/p2p/discover.ListenV4 in goroutine 1
github.com/ethereum/go-ethereum/p2p/discover/v4_udp.go:150 +0x3a8

@NathanHo1024
Copy link
Author

Could you please provide the panic log? Your image is not resolved.

And than, i add two static node to the config. but it still doesn't work. The panic has happen again.

@lilasxie
Copy link
Contributor

lilasxie commented May 28, 2024

I'm wondering why we should panic here.
https://github.com/ethereum/go-ethereum/blob/master/p2p/discover/table_reval.go#L173~L175

if !source.remove(n) {
	panic(fmt.Errorf("moveToList(%q -> %q): node %v not in source list", source.name, dest.name, n.ID()))
}

If the source list doesn't contain the node, just leave a warning log will that be ok?

@NathanHo1024
Copy link
Author

I'm wondering why we should panic here. https://github.com/ethereum/go-ethereum/blob/master/p2p/discover/table_reval.go#L173~L175

if !source.remove(n) {
	panic(fmt.Errorf("moveToList(%q -> %q): node %v not in source list", source.name, dest.name, n.ID()))
}

If the source list doesn't contain the node, just leave an unexpected warning log will that be ok?

so i need change the source code and rebuild again?

@rjl493456442
Copy link
Member

rjl493456442 commented May 28, 2024

@NathanHo1024 Please wait a bit, we will investigate the panic.

As now, you could downgrade your node to latest release https://github.com/ethereum/go-ethereum/releases/tag/v1.14.3
It should work without issue.

@NathanHo1024
Copy link
Author

@NathanHo1024 Please wait a bit, we will investigate the panic.

As now, you could downgrade your node to latest release https://github.com/ethereum/go-ethereum/releases/tag/v1.14.3 It should work without issue.

ok, thanks. bro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants