Sparse merkle tree part1 #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikluhn
reviewed
Jul 16, 2018
trie/constants.py
Outdated
| from eth_hash.auto import keccak | ||
| EMPTY_LEAF_NODE_HASH = BLANK_HASH | ||
| EMPTY_NODE_HASHES = [EMPTY_LEAF_NODE_HASH] | ||
| for _ in range(159): |
There was a problem hiding this comment.
As 160 (and 159) is used a couple of times, it would make sense to make it a constant. Maybe NODE_BIT_LENGTH?
There was a problem hiding this comment.
Agree, what do you think about maybe something more straight forward like TREE_HEIGHT?
trie/sparse_merkle_tree.py
Outdated
| target_bit >>= 1 | ||
|
|
||
| if self.db[node_hash] is b'': | ||
| return None |
There was a problem hiding this comment.
Reason for returning None instead of raising a KeyError? We've found that return value checking is way easier to forget than exception handling.
There was a problem hiding this comment.
No particular reason. Just that in hexary trie, BLANK_NODE is returned for non-existent key. Raising an exception does make more sense.
|
@pipermerriam Updated the behavior for handling non-existent key and ready for review again. |
kclowes
added a commit
to kclowes/py-trie
that referenced
this pull request
Nov 30, 2022
Update template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Try out Sparse Merkle Tree for sharding research.
How was it fixed?
Implement Sparse Merkle Tree as described in #37.
Cute Animal Picture